YunoHost-Apps / friendica_ynh

Friendica package for YunoHost
http://friendi.ca/
Other
11 stars 13 forks source link

Error with debian stretch #5

Closed Josue-T closed 6 years ago

Josue-T commented 6 years ago

Hello,

I did the migration to debian stretch. Actually I have a problem with your package. While I try to a un upgrade the package with the vFriendica_2018.05 branch I get this :

+ pkg_dependencies='php7.0-cli php7.0-imagick php7.0-gd php7.0-mcrypt'
++ lsb_release --codename --short
+ '[' stretch '!=' jessie ']'
+ pkg_dependencies='php7.0-cli php7.0-imagick php7.0-gd php7.0-mcrypt php-xml'
+ ynh_install_app_dependencies php7.0-cli php7.0-imagick php7.0-gd php7.0-mcrypt php-xml
+ local 'dependencies=php7.0-cli php7.0-imagick php7.0-gd php7.0-mcrypt php-xml'
+ local 'dependencies=php7.0-cli, php7.0-imagick, php7.0-gd, php7.0-mcrypt, php-xml'
+ local 'dependencies=php7.0-cli, php7.0-imagick, php7.0-gd, php7.0-mcrypt, php-xml'
+ local manifest_path=../manifest.json
+ '[' '!' -e ../manifest.json ']'
++ cut -d '"' -f 4
++ grep '\"version\": ' ../manifest.json
+ local version=2018.05
+ '[' 7 -eq 0 ']'
+ local dep_app=friendica
+ cat
+ ynh_package_install_from_equivs /tmp/friendica-ynh-deps.control
+ local controlfile=/tmp/friendica-ynh-deps.control
+ ynh_package_is_installed equivs
+ dpkg-query -W -f '${Status}' equivs
+ grep -c 'ok installed'
++ grep '^Package: ' /tmp/friendica-ynh-deps.control
++ cut '-d ' -f 2
+ local pkgname=friendica-ynh-deps
++ grep '^Version: ' /tmp/friendica-ynh-deps.control
++ cut '-d ' -f 2
+ local pkgversion=2018.05
+ [[ -z friendica-ynh-deps ]]
+ [[ -z 2018.05 ]]
+ ynh_package_update
+ ynh_apt update
+ DEBIAN_FRONTEND=noninteractive
+ sudo apt-get -y update
Ign:1 http://ftp.ch.debian.org/debian stretch InRelease
Atteint:2 http://security.debian.org stretch/updates InRelease
Atteint:3 http://forge.yunohost.org/debian stretch InRelease
Atteint:4 http://ftp.ch.debian.org/debian stretch-updates InRelease
Atteint:5 http://ftp.ch.debian.org/debian stretch Release
Lecture des listes de paquets…
++ mktemp -d
+ local TMPDIR=/tmp/tmp.AyXIrOjVg1
+ echo 10
+ cp /tmp/friendica-ynh-deps.control /tmp/tmp.AyXIrOjVg1/control
+ cd /tmp/tmp.AyXIrOjVg1
+ equivs-build ./control
+ sudo dpkg --force-depends -i ./friendica-ynh-deps_2018.05_all.deb
(Lecture de la base de données... 91991 fichiers et répertoires déjà installés.)
Préparation du dépaquetage de .../friendica-ynh-deps_2018.05_all.deb ...
Dépaquetage de friendica-ynh-deps (2018.05) sur (2018.05) ...
dpkg: friendica-ynh-deps : problèmes de dépendances, mais configuration comme demandé :
 friendica-ynh-deps dépend de php7.0-imagick ; cependant :
  Le paquet php7.0-imagick n'est pas installé.

Paramétrage de friendica-ynh-deps (2018.05) ...
+ ynh_package_install -f

I think you need to adapt your dependances for debian stretch maybe. You probably need to replace php5-imagick by php-imagick

anmol26s commented 6 years ago

Thanks for pointing that out. I didn't had issue with it because some how php-imagick was already installed and it did not gave error for it. I changed php5-imagick to php-imagick in this branch https://github.com/YunoHost-Apps/friendica_ynh/tree/vFriendica_2018.05. You can test it after that I will merge it into master. Thanks

Josue-T commented 6 years ago

Thanks for your quick fix but are you sure that php-imagick are available on debian jessie (for retro-compatibility) ?

anmol26s commented 6 years ago

I think this itself install the version required for the php which is set here ls -l /etc/alternatives/php. Correct me if I am wrong.

Josue-T commented 6 years ago

I think this itself install the version required for the php which is set here ls -l /etc/alternatives/php. Correct me if I am wrong.

No, because it's managed by apt and apt don't really like when where are some problem about the dependence.

I think the best solution to fix all problem about the compatibility with stretch is to use that :

ynh_install_app_dependencies php5-cli 'php5-imagick|php-imagick' php5-gd php5-mcrypt 'php-xml|base-files(<<9.0)'

Which mean "php5-imagick or php-imagick" and "debian <9 or php-xml". I have tried that on debian jessie and stretch and it work well.

anmol26s commented 6 years ago

Thanks for your the solution and clearing my doubt. I have pushed your solution to the vFriendica_2018.05 and test it. If this works I will do the same solution for HubZilla package too.

Josue-T commented 6 years ago

Hello,

It work for me. Thanks