Closed anmol26s closed 3 years ago
!testme
!testme
!testme
!testme
!testme
why switching to git ? and if switching to git, why keeping app.src ?
why switching to git ?
and if switching to git, why keeping app.src ?
The git works for new installation of the app and for future upgrades. But for users who have installed the app before this release, will have to rely on the app packaging cycling, unless they themself do the changes to make the app use git. Right now while upgrade the script checks if the main folder have git. If it finds git, then it would use git to update the app otherwise it would use the normal way to update. So if git is not there in app's main folder then normal upgrade will run and use app.src to update.
As discuss, if you want to switch the package to git, no problem but previous installation has to be switched to git and for security reason it's better to use the commit ID instead of the tag
!testme
As I detailed here https://github.com/YunoHost-Apps/friendica_ynh/issues/48#issuecomment-876879220 it failed to upgrade my friendica. Error:
3356 WARNING _common.sh: line 33: syntax error near unexpected token `elif'
3356 WARNING _common.sh: line 33: ` elif is_there_enough_space /home; then'
587679 WARNING fatal: not a git repository (or any of the parent directories): .git
587681 WARNING ./upgrade: line 116: ynh_smart_mktemp: command not found
657350 WARNING userdel: user friendica is currently used by process 5289
657351 WARNING /usr/sbin/deluser: `/sbin/userdel friendica' returned error code 8. Exiting.
657527 WARNING /usr/sbin/delgroup: `friendica' still has `friendica' as their primary group!
I'd like to use git but I'd also like not to break my instance of over 100 users....let me know if I can be of any help by testing stuff.
Problem
Solution
PR Status