search

YunoHost-Apps / friendica_ynh

Friendica package for YunoHost
http://friendi.ca/
Other
11 stars 13 forks source link

Remove main folder at upgrade - Good practice ? #8

Closed Josue-T closed 6 years ago

Josue-T commented 6 years ago

I discovered in the upgrade script in line 45 at each upgrade we remove everything. Is it a really a good practice because we have some which is useful (by example in $finalpath/proxy and $finalphat/photo ).

anmol26s commented 6 years ago

See this: https://github.com/friendica/friendica/issues/3589#issuecomment-317039372 and the upgrade procedure described here https://github.com/friendica/friendica/releases. If you think these files/folders are important and is breaking something then please advise the folders to be backed up. Otherwise removing this line should not break anything,I guess. I did this clean upgrade as advised in the upgrade procedure for Friendica.

Josue-T commented 6 years ago

Yes, but as I understand the $finalpath/proxy and $finalphat/photo is not really necessary but probably something more like a cache. But as I tested friendica is really heavy so it could be good to not force friendica to remake the cache at each upgrade. But it stay my point of view.

anmol26s commented 6 years ago

Thanks for referring the cache issue. I have made you admin of the project. I personally have more inclination towards Hubzilla app. So I never used this package but kept it updating because I thought some day I will install both the project together and do deep comparison. That day never came. Now that you are using the this app and have the skill to improve it, I invite you to improve this app. I have subscribed to Friendica support form to get there updates but I might miss them and you are in better position to keep a check on them. Moreover apps level has to be pulled up from 4 to 7. So you are in better position to see the issues of the app.

I have started testing branch in which I have removed ynh_secure_remove "$final_path", you can upgrade and if everything works you can merge into master.