YunoHost-Apps / friendica_ynh

Friendica package for YunoHost
http://friendi.ca/
Other
11 stars 13 forks source link

Use correct commit hashes for 22.10 and addons. #83

Closed ndarilek closed 1 year ago

ndarilek commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

tituspijean commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:v: Test Badge

tituspijean commented 1 year ago
tio-trom commented 1 year ago
  • [ ] Check "upgrade-but actually downgrade" from 22.10~ynh1 to 22.10~ynh2

I am starting a conversation with the Frienedica admins and developers here https://social.trom.tf/display/dbc8dc44-1763-7a10-2c3e-2f1003184441 - it seems to be a bad idea to push now a change from the dev version (december) to a stable version (september). It will likely break the installations completely.

The september stable version is kinda buggy anyway and they plan to release another stable in december, maybe wait for that and push an update to that when it is out.

Quix0r commented 1 year ago

Hello all,

a $ git diff upstream/develop..upstream/stable static/dbstructure.config.php tells me that there are changes done to the database tables since last time stable branch was updated. I won't try a downgrade from develop back to stable. The change on file/GIT commit side is trivial: $ git checkout stable but the following needed changes (as your database tables have changed during the upgrade) can be a really bad nightmare.

So you only have 2 safe options left: Remain on develop or restore an old backup before the upgrade to develop code.

tio-trom commented 1 year ago

So, Friendica's developers plan to release another stable in december. Please for now leave this package as it is, with the development branch, and update in december to the stable one once it is released, so that you upgrade from dev to stable in a chronological order. Else if you try to now update this package with an older release (the stable branch) compared to the one is currently using, then those who upgraded their ynh friendica and update again, will have their instances nuked basically, from what I understand, and no easy way (or any way) to fix it.

In essence do not update from a newere version of friendica to an older one.