Update to friendica stable 2023.05

[Tagadda]

!testme

[yunohost-bot]

Alrighty!

[tio-trom]

140397 INFO WARNING - ERROR 1146 (42S02) at line 1: Table 'friendica.addon' doesn't exist

I see that in the testing. Anyone able to figure what's about?

[MrPetovan]

This is the part of the full log related to the command that should create the addon database table that is not found later:

60859 DEBUG  ynh_mysql_connect_as --user=friendica --password=QhcoXP8I13G3syRBR4rUs1Li --database=friendica
60859 DEBUG  local legacy_args=upd
60859 DEBUG  args_array=(['u']='user=' ['p']='password=' ['d']='database=')
60860 DEBUG  local -A args_array
60860 DEBUG  local user
60860 DEBUG  local password
60860 DEBUG  local database
60860 DEBUG  ynh_handle_getopts_args --user=friendica --password=QhcoXP8I13G3syRBR4rUs1Li --database=friendica
60860 DEBUG  set +o xtrace
60907 DEBUG  database=friendica
60907 DEBUG  mysql --user=friendica --password=QhcoXP8I13G3syRBR4rUs1Li --batch friendica

There's no reference to the expected database.sql file that include database table creation statements as per the related YunoHost statement: https://github.com/YunoHost-Apps/friendica_ynh/blob/dc7cd3eabe212708375c0dcd4ee994a1373a8122/scripts/install#L126-L127

Has the ynh_mysql_connect_as syntax changed recently?

[MrPetovan]

In the current develop version the addon table has been removed. The correct way to enable the ldapauth addon which would also work in version 2023.05 is the following CLI command:

bin/console addon enable ldapauth

I'm not sure how it should be written in the YunoHost script.

[MrPetovan]

I've created a separate PR that should fix the MySQL error. I'm not able to test my changes however.

[MrPetovan]

This should be rebased on the latest testing including the removal of explicit database calls and tested again.

[tio-trom]

I tried to update from Testing and it failed. Here are the logs https://paste.yunohost.org/raw/ejicinipof

2023-08-21 00:14:45,012: WARNING - rm: cannot remove '/var/www/friendica/view/smarty3/compiled': Directory not empty

Maybe is just a simple thing that needs to be fixed!?

[MrPetovan]

It looks like your existing Yunohost installation didn't use Git initially which prompts the upgrade to go the alternate upgrade route: https://github.com/YunoHost-Apps/friendica_ynh/blob/dc7cd3eabe212708375c0dcd4ee994a1373a8122/scripts/upgrade#L127-L154

I'm not sure why the smarty3 folder is saved in the temp folder and restored later but the safe delete should work: https://github.com/YunoHost-Apps/friendica_ynh/blob/dc7cd3eabe212708375c0dcd4ee994a1373a8122/scripts/upgrade#L135

Would you be able to log in your Yunohost server and figure out what's in the smarty3/compiled folder that can't be deleted?

[tio-trom]

Interesting....

This is what I have in that folder:

Many folders named 00 01 02...

[tio-trom]

I could delete the folder like you suggested and try again. Just waiting for a backup now to make sure I won't nuke my instance. Already restored from a snapshot because of the above failed attempt :D

EDIT: Eh sorry I misunderstood. Of course not to delete that folder.

Would you be able to log in your Yunohost server and figure out what's in the smarty3/compiled folder that can't be deleted?

I am unsure how that can be achieved. I will have a look. Thanks a lot.

[tio-trom]

Maybe I should wait until all Merge Requests land in the Testing like https://github.com/YunoHost-Apps/friendica_ynh/pull/102 ones. Then I can properly test on my own instance.

[ericgaspar]

Closing in favor of #99