YunoHost-Apps / funkwhale_ynh

A modern, convivial and free music server on YunoHost
https://funkwhale.audio/
GNU Affero General Public License v3.0
72 stars 22 forks source link

Update with the 1.3.4 version #257

Closed stilobique closed 10 months ago

stilobique commented 10 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Thovi98 commented 10 months ago

May I also ask you to update the tests.toml?

Thanks for the PR!

stilobique commented 10 months ago

May I also ask you to update the tests.toml?

Thanks for the PR!

Is simply the commit identifier ? It's add.

Thovi98 commented 10 months ago

!testme !bookwormtestme

yunohost-bot commented 10 months ago

:books: :bug: Test Badge

yunohost-bot commented 10 months ago

:v: Test Badge

Thovi98 commented 10 months ago

@stilobique May I ask you where you took the commit number from in tests.toml? It has to be the latest commit refernence in master branch :) I have 88dd43d

Thovi98 commented 10 months ago

Okay, for reference, the commit didn't work because we forgot to update the package version in manifest.toml :)

stilobique commented 10 months ago

Okay, for reference, the commit didn't work because we forgot to update the package version in manifest.toml :)

Oh, I think I mixed up the branches when I took the commit ID. Thanks for your explain @Thovi98 , the next time I make a PR without issue 🔥 !