search

YunoHost-Apps / funkwhale_ynh

A modern, convivial and free music server on YunoHost
https://funkwhale.audio/
GNU Affero General Public License v3.0
72 stars 22 forks source link

Is opening of the port required? #50

Closed anmol26s closed 5 years ago

anmol26s commented 5 years ago

Hi As the Funkwhale and Nginx are on same server, do we need to open the port for the outer web? https://github.com/YunoHost-Apps/funkwhale_ynh/blob/master/scripts/install#L66

Most of the time we don't need to open the port and it can be security concern.

agateblue commented 5 years ago

From Funkwhale's perspective there is indeed no need to have this exposed to the outside world, and as you guessed, it raises potential security concerns, so I assume we can safely remove it @Jibec

Jibec commented 5 years ago

hello, should be fixed by this: https://github.com/YunoHost-Apps/funkwhale_ynh/commit/c22807493ed23582bc9770d765a69cc1fb337953