YunoHost-Apps / funkwhale_ynh

A modern, convivial and free music server on YunoHost
https://funkwhale.audio/
GNU Affero General Public License v3.0
72 stars 22 forks source link

change UI upload size limit #55

Closed IsidoreIsou closed 5 years ago

IsidoreIsou commented 5 years ago

Hello everyone,

What would be the right way on a YunoHost install of Funkwhale to change the size limit when uploading a music file from the UI ? Now it's 32MB.

Thanks!

IsidoreIsou commented 5 years ago

I've tried to nano this file:

funkwhale_ynh/conf/nginx.conf

and to edit this line:

client_max_body_size 30M; to put a higher value,

but it doesn't work. Help!

IsidoreIsou commented 5 years ago

Solved, here is the file to edit:

/etc/nginx/conf.d/yourdomain.d/funkwhale.conf

Jibec commented 5 years ago

please remember your change will be erased at each update of the funkwhale package

@EliotBerriot : do you think using a higher value is safe? does it makes sense to you?

agateblue commented 5 years ago

We could probably increase this, the main risk is having user accidentally (or voluntarily in case of an attack) exhausting the server resources by uploading large files. Setting a higher limit (let's say 100MB) will not break anything, it's just a tradeof to consider between security/stability and functionality.

That being said, I'd probably increase the default limit to 50 or 100MB in our sample files because we've got plenty of support tickets and questions about this :)

Jibec commented 5 years ago

OK thanks. I prefer you changing the default and me following your suggestion. So the user experience is consistent.

agateblue commented 5 years ago

I created a ticket for that: https://dev.funkwhale.audio/funkwhale/funkwhale/issues/654

Jibec commented 5 years ago

OK, I see it is now upstream, I will update it to 100 MB

agateblue commented 5 years ago

:ok_hand: @Jibec, sorry, I forgot to ping you back once it was done!

Jibec commented 5 years ago

fixed by https://github.com/YunoHost-Apps/funkwhale_ynh/commit/9c6ee6e951e898c5c4e1ad8e8d4fe168c23eaef9