YunoHost-Apps / funkwhale_ynh

A modern, convivial and free music server on YunoHost
https://funkwhale.audio/
GNU Affero General Public License v3.0
73 stars 22 forks source link

Raven error reporting not cleanly managed #73

Closed Josue-T closed 5 years ago

Josue-T commented 5 years ago

Hello,

Seeing the config file I discovered that in the config file is not well cleanly implemented. Here is the content which I found that is not really clean. Probably the RAVEN_DSN value should be updated to something else...

# Sentry/Raven error reporting (server side)
# Enable Raven if you want to help improve funkwhale by
# automatically sending error reports our Sentry instance.
# This will help us detect and correct bugs
RAVEN_ENABLED=false
RAVEN_DSN=https://44332e9fdd3d42879c7d35bf8562c6a4:0062dc16a22b41679cd5765e5342f716@sentry.eliotberriot.com/5
Jibec commented 5 years ago

hello Josue, what would you expect?

Josue-T commented 5 years ago

The question is: it normal that we have this static value for all funkwall instance ?

44332e9fdd3d42879c7d35bf8562c6a4:0062dc16a22b41679cd5765e5342f716
Jibec commented 5 years ago

I think it doesn't really matter as raven is disabled: RAVEN_ENABLED=false

Josue-T commented 5 years ago

Oh is didn't see that.