YunoHost-Apps / galene_ynh

Galène package for YunoHost
https://galene.org/
GNU General Public License v3.0
10 stars 3 forks source link

Does port 8443 need to be opened? #34

Closed h3ndrik closed 3 years ago

h3ndrik commented 3 years ago

My yunohost warns me that "Port 8443 is not reachable from outside". Is there any reason behind using both nginx as a reverse proxy and also opening the internal port directly to the internet?

If not: please consider removing that firewall directive. It also circumvents any authentication and security measures by nginx if the service is reachable via another port.

https://github.com/YunoHost-Apps/galene_ynh/blob/824143672c8aa5c64522a43636d4d369820a893b/scripts/install#L88

ericgaspar commented 3 years ago

Thanks for pointing it out. This should be corrected with #35