Testing

[rodinux]

Problem

• update to last release 1.1.10

Solution

• add a php7-4 configuration with repository surry
• change permissions on files

PR Status

• [ x] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[rodinux]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[rodinux]

I am not sure with the file pull_request_template.md. I remember it was a pull request from someone of the community, is it a right way ? These changes have been yet approved on the PR https://github.com/YunoHost-Apps/garradin_ynh/pull/53 but I think it is a better way to do it from testing branch, after that I will mark the other PR as Draft, is a good idea ? I don't know how delete a PR... The branch 1.1.5 is still a branch to upgrade and test the last releases for now....

[alexAubin]

The pull request is fine, this is now the standard template accross yunohost apps ...

[alexAubin]

Beware though that the CI is complaining about unsafe perms for /var/www/$app:

Error: It looks like anybody can read/enter /var/www/garradin, which ain't super great from a security point of view ... Config files or other files may contain secrets or information that should in most case not be world-readable. You should remove all 'others' permissions with 'chmod o-rwx', and setup appropriate, exclusive permissions to the appropriate owner/group with chmod/chown.

[rodinux]

Beware though that the CI is complaining about unsafe perms for /var/www/$app:

Error: It looks like anybody can read/enter /var/www/garradin, which ain't super great from a security point of view ... Config files or other files may contain secrets or information that should in most case not be world-readable. You should remove all 'others' permissions with 'chmod o-rwx', and setup appropriate, exclusive permissions to the appropriate owner/group with chmod/chown.

Yes, I did not find how to resolve this. I have try change some permissions on the directory and files and it is better than before, but not enough...

[alexAubin]

!testme

[yunohost-bot]

Meow :cat2:

[rodinux]

Nice, the the rewiew fix-permissions works ! I wait to see if the PR Cleaning up https://github.com/YunoHost-Apps/garradin_ynh/pull/58 works also, but I don't now why it seems fail on the CI...

[rodinux]

It seems be important to merge on the branch master, I have issues on virtual machine to install garradin from the master branch...

[rodinux]

Nice, the the rewiew fix-permissions works ! I wait to see if the PR Cleaning up #58 works also, but I don't now why it seems fail on the CI...

It's good, I merge the PR Cleaning-up, now waiting a reviewer to merge on master branch

[rodinux]

Perhaps just delete the test on pull_request upgrade from commit line 18 since reviewing....

[rodinux]

hello, does anyone accept review this PR ? So we could push it on master branch ? Do you agree @frju365 @ericgaspar @alexAubin ?

[alexAubin]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[rodinux]

Ok, I have merged a little quickly... I realize trying on a virtual machine, first I install a 0.9.8.1 version, do the pre-install, next upgrading with this code to 1.1.10, I have to do a new pre-install, the one before was deleted... Perhaps, also because It needed add more datas before ?? But I don't worry so much, there is sql backups on the app.

[rodinux]

Ok, I see where is the problem. Perhaps I need remove ynh_secure_remove $backup_squelettes and ynh_secure_remove $backup_bdd on the first upgrade to 0.9.8.1, but I am not sure...