Cleaning up - Githubissues

YunoHost-Apps / garradin_ynh

Logiciel libre de gestion associative pour YunoHost

https://garradin.eu/

GNU General Public License v3.0

7 stars 8 forks source link

Cleaning up #58

Closed ericgaspar closed 3 years ago

ericgaspar commented 3 years ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 3 years ago

!testme

yunohost-bot commented 3 years ago

May the CI gods be with you!

rodinux commented 3 years ago

!testme

rodinux commented 3 years ago

Why the CI crashed with these changes ? Perhaps because of the lines from line 18 in the file check_process ?

;;; Options
Email=
Notification=none
;;; Upgrade options
    ; commit=a36dd8b13d85078ddcee0d6d3146feb107d3e042
        name=Merge pull request #55 from yunohost-bot/issue-and-pr-template 
        manifest_arg=domain=DOMAIN&path=PATH&admin=USER&language=fr&is_public=1&password=pass&port=666&

rodinux commented 3 years ago

Ok, I was waitong the result of the CLI, it seems more clean code, nice !