YunoHost-Apps / garradin_ynh

Logiciel libre de gestion associative pour YunoHost
https://garradin.eu/
GNU General Public License v3.0
7 stars 8 forks source link

add a message for admins #99

Closed rodinux closed 1 year ago

rodinux commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

rodinux commented 1 year ago

Hello, someone to review ? @ericgaspar ? @fflorent ?

rodinux commented 1 year ago

!testme

This will be the last steps inviting each user migrate to paheko

yunohost-bot commented 1 year ago

:sunflower: Test Badge

rodinux commented 1 year ago

!testme

yunohost-bot commented 1 year ago

May the CI gods be with you! Test Badge

rodinux commented 1 year ago

You need to bump to the version 1.2.4~ynh2 in the manifest

Oups ! Thanks...

rodinux commented 1 year ago

I have a doubt, first looking for few apps with a send massage, I think there is no " at the end as you suggest, Looking at the linter analysis

  Analyzing app /tmp/package_check.J6Vaab/app_folder ...
Some lines could not be parsed in script _common.sh. (That's probably not really critical)
? No closing quotation : $(yunohost tools diagnosis | grep -B 100 "services:" | sed '/services:/d')" 
Some lines could not be parsed in script upgrade. (That's probably not really critical)
? No closing quotation : message="Garradin was successfully upgraded :) 
? No closing quotation : Garradin becomes Paheko. You can now upgrade Garradin with Paheko ! Don't stay with this repository, it will be no more supported. 
? No closing quotation : This can only be done from the command-line interface - e.g. through SSH. Once you're connected, you simply have to execute the following: 
? No closing quotation : Important: After the migration, you'll have to wait a couple of minutes (at most 3 minutes) before you can start using Paheko." 

second, this app have no admin user., does the script look for an admin user to sen mail ???

rodinux commented 1 year ago

Hum, no, the code seems goos like this... it's OK now. \o/

rodinux commented 1 year ago

Could we push this update ? a review or is it OK ? @ericgaspar @fflorent ?

rodinux commented 1 year ago

!testme

I think I found the quote error...

yunohost-bot commented 1 year ago

:carousel_horse: Test Badge

rodinux commented 1 year ago

Is it better doing like this ? https://github.com/YunoHost-Apps/garradin_ynh/pull/99/commits/e4f670a8d8fcf1532022b8cfcba4c0bb8a8f893d

rodinux commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Meow :cat2: Test Badge