search

YunoHost-Apps / gogs_ynh_old

Gogs package for YunoHost
https://gogs.io
MIT License
15 stars 5 forks source link

User creation forgotten in install script #6

Closed stevenroose closed 9 years ago

stevenroose commented 9 years ago

It seems weird that noone noticed this, so I think maybe the gogs user is created by one of the yunohost calls.

But here in the install script https://github.com/mbugeia/gogs_ynh/blob/master/scripts/install#L33 The gogs user is mentioned before it is created.

mbugeia commented 9 years ago

The user is created by the deb package so it's not an issue. BTW don't use this package, it's broken right now.

stevenroose commented 9 years ago

I wasnt planning to use it until LDAP integration works, but I was considering to try to fix that myself. How comes its broken?

On Mon, May 25, 2015 at 3:08 PM, tostaki notifications@github.com wrote:

The user is created by the deb package so it's not an issue. BTW don't use this package, it's broken right now.

— Reply to this email directly or view it on GitHub https://github.com/mbugeia/gogs_ynh/issues/6#issuecomment-105229389.

mbugeia commented 9 years ago

Well don't remember exactly what's broken but I use the debian package https://packager.io/gh/pkgr/gogs and an update broke it. Since it's written in Go I think it's better to use binary with yunohost because there is no risk to broke it with an update. Moreover IMHO the debian package is not very good, for example it create 3 service instead of one...

I've done some work for this, you can look at the unstable branche but it's not functionnal yet. Init script don't work (maybe this PR will correct it https://github.com/gogits/gogs/pull/1274). Unfortunatly I will not have time to work on it until july so if you want to fork/improve it, it would be appreciated.

stevenroose commented 9 years ago

Whats the benefit of a deb package over just installing Go and registering a service manually that runs the Go executable?

On Mon, May 25, 2015 at 4:22 PM, tostaki notifications@github.com wrote:

Well don't remember exactly what's broken but I use the debian package https://packager.io/gh/pkgr/gogs and an update broke it. Since it's written in Go I think it's better to use binary with yunohost because there is no risk to broke it with an update. Moreover IMHO the debian package is not very good, for example it create 3 service instead of one...

I've done some work for this, you can look at the unstable branche but it's not functionnal yet. Init script don't work (maybe this PR will correct it gogits/gogs#1274 https://github.com/gogits/gogs/pull/1274). Unfortunatly I will not have time to work on it until july so if you want to fork/improve it, it would be appreciated.

— Reply to this email directly or view it on GitHub https://github.com/mbugeia/gogs_ynh/issues/6#issuecomment-105242453.

mbugeia commented 9 years ago

None except easier installation and easier update (in theory). That's why I want to switch to binary.

stevenroose commented 9 years ago

The upgrade script could just pull the latest stable from GitHub and compile. Well, I'm installing a YunoHost in August, perhaps I'll take a look at Gogs and update this script to work with LDAP and binaries.

On Mon, May 25, 2015 at 4:29 PM, tostaki notifications@github.com wrote:

None except easier installation and easier update (in theory). That's why I want to switch to binary.

— Reply to this email directly or view it on GitHub https://github.com/mbugeia/gogs_ynh/issues/6#issuecomment-105243914.