Fix accounts keys (settings not kept during upgrade)

ericgeldmacher commented 1 year ago

Problem

Accounts config settings not being kept after upgrade.
[main.accounts.{key}] in config_panel.toml do not match up with keys used in install, restore, and upgrade scripts.

Solution

Change [main.accounts.{key}] to [main.accounts.accounts_{key}] in config_panel.toml.
Add section to upgrade script to apply values from problem key to correct key.

PR Status

[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
- config_panel.toml (tested)
- upgrade script (not tested)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgeldmacher commented 1 year ago

Sorry, not meaning to spam PRs. Tried to get this in before 0.8.0~ynh2 was merged into master.

OniriCorpe commented 1 year ago

Accounts config settings not being kept after upgrade. [main.accounts.{key}] in config_panel.toml do not match up with keys used in install, restore, and upgrade scripts.

nice catch!