Allow CSS setting is not kept on upgrade

YunoHost-Apps / gotosocial_ynh

GoToSocial package for YunoHost: an ActivityPub social network server, written in Golang.

https://gotosocial.org

Other

10 stars 6 forks source link

Allow CSS setting is not kept on upgrade #76

Closed xmgz closed 1 year ago

xmgz commented 1 year ago

Describe the bug

most instance settings are corretly set to previous values after upgrading, but "allow personal css" is not.

Context

gotosocial 0.8.0 (it happens since previous versions too) in latest stable YNH server (11.1.17, 64bit, etc.)

Steps to reproduce

set "allow css" to true in yunohost gotosocial config panel.
upgrade gotosocial

Expected behavior

true (or value set) should persist on upgrading as other values in config panel do

Thank you.

OniriCorpe commented 1 year ago

Hi!

This issue was fixed yesterday in the v0.8.0~ynh3 ^w^

To be sure, I just tested with a modified configuration, including the custom css parameter, and I forced an update on my test instance, and the parameters were well preserved

A screenshot of the config panel on the part relating to the accounts, with a modified configuration, including that on the custom CSS

So, everything should be fine now

If you want to test this, you can do it with this command: yunohost app upgrade gotosocial -u https://github.com/YunoHost-Apps/gotosocial_ynh/tree/master --force

OniriCorpe commented 1 year ago

I close, do not hesitate to answer if the bug is still present for you with the last version