The hotspot app is tightly coupled with the vpnclient, which creates side effects difficult to debug.
Solution
I'm using the openvpn hooks to trigger a restart of the hotspot service whenever the VPN connects / disconnects.
There is room for optimization, but they would require more refactoring.
I'm not really happy with the need to create /etc/openvpn/scripts folders and subfolders, but this is needed if the hotspot app is installed before the openvpn app...
PR Status
[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
Problem
The hotspot app is tightly coupled with the vpnclient, which creates side effects difficult to debug.
Solution
I'm using the openvpn hooks to trigger a restart of the hotspot service whenever the VPN connects / disconnects.
There is room for optimization, but they would require more refactoring.
I'm not really happy with the need to create /etc/openvpn/scripts folders and subfolders, but this is needed if the hotspot app is installed before the openvpn app...
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)