YunoHost-Apps / hotspot_ynh

Wifi Hotspot app for YunoHost
GNU Affero General Public License v3.0
39 stars 19 forks source link

[wip] Remove multissid and enable multi instance #107

Closed hidrarga closed 10 months ago

hidrarga commented 11 months ago

Problem

Closes #100

Solution

While I'm removing the multi SSID to make the app cleaner and simpler, I'm also enabling installation of multiple instances of the app. The user will be able to install one hotspot app per wifi device. The downside is that they won't be able to have multiple SSID on the same device (we could add this feature later, for instance by adding a "guest hotspot" option).

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

hidrarga commented 11 months ago

!testme

yunohost-bot commented 11 months ago

:carousel_horse: Test Badge

hidrarga commented 11 months ago

I noticed that when usb devices are reloaded (see hot_reload_usb_wifi_cards function), all wireless device would go down. I don't have an easy solution for this right now, except manually restarting related hotspot :/

hidrarga commented 11 months ago

!testme

yunohost-bot commented 11 months ago

:v: Test Badge

hidrarga commented 11 months ago

!gogogadgetoci

yunohost-bot commented 11 months ago

Alrighty! Test Badge