YunoHost-Apps / hotspot_ynh

Wifi Hotspot app for YunoHost
GNU Affero General Public License v3.0
39 stars 19 forks source link

Configure IPv6 only when VPN is up and fix default route for IPv6 #124

Open hidrarga opened 3 months ago

hidrarga commented 3 months ago

Problem

The IPv6 delegated prefix is meant to be used with the VPN client, but the IPv6 address is always configured, even when there is no VPN active.

I also noticed the default route for IPv6 is removed when IPv6 forwarding is enabled.

Solution

I'm configuring the IPv6 in the scripts for the VPN. This way, when the VPN is up, the IPv6 address is added to the wifi interface. Also, when the hotspot is starting, it checks if the VPN is already up before adding the IPv6.

I'm adding back the default route after enabling IPv6 forwarding.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

hidrarga commented 3 months ago

!testme

yunohost-bot commented 3 months ago

:v: Test Badge

yunohost-bot commented 3 months ago

:worm: Test Badge