search

YunoHost-Apps / hotspot_ynh

Wifi Hotspot app for YunoHost
GNU Affero General Public License v3.0
39 stars 19 forks source link

use `systemctl is-enabled` instead of app variable #42

Closed keomabrun closed 5 years ago

keomabrun commented 5 years ago

Currently the status (enabled/disabled) of the ynh-hotspot service is managed as an app variable. I believe it should be using systemctl is-enabled instead.

keomabrun commented 5 years ago

The only (potentially harmful) drawback I see is that the web interface would have to have access to systemctl.

Any suggestions ?

alexAubin commented 5 years ago

Eh, not sure to understand why that's a drawback ? The user already has sudo-access so ? :D

keomabrun commented 5 years ago

It does. And it should not :cry: