search

YunoHost-Apps / hotspot_ynh

Wifi Hotspot app for YunoHost
GNU Affero General Public License v3.0
39 stars 19 forks source link

Force firmware_nonfree to no on armbian #54

Closed alexAubin closed 5 years ago

alexAubin commented 5 years ago

This is a fix for https://github.com/labriqueinternet/hotspot_ynh/issues/30

It is too easy to forget to set this setting to no when running an internet cube install using the armbian images and this miserably breaks the whole installation ...

N.B. : I did not actually test it though ...

alexAubin commented 5 years ago

Bump ;D

I can haz reviews ?

keomabrun commented 5 years ago

Tested. Works, but tiny dpkg error:

31218 DEBUG + echo 'You are running Armbian and non-free firmware are known to conflict with armbian-firwmare. '
31220 WARNING dpkg-query: error: error writing to '<standard output>': Broken pipe
31226 DEBUG + firmware_nonfree=no
31229 WARNING You are running Armbian and non-free firmware are known to conflict with armbian-firwmare.
31237 DEBUG + echo 'Variable firmware_non_free has been forced to '\''no'\'''
31240 WARNING Variable firmware_non_free has been forced to 'no'
alexAubin commented 5 years ago

Uh that's weird ... I can't reproduce the issue if I run dpkg --list | grep -q armbian in an interactive shell :|

alexAubin commented 5 years ago

We should add it to the upgrade script (for older installs)

Theoretically yes, but considering the context I doubt it's necessary : it's only since recently that we started to make armbian-based image for the internet cube. And before that, basically installing hotspot_ynh would fail. So I don't think we really need to because I don't see how you could have ended up in that kind of situation :s

keomabrun commented 5 years ago

I am okay for merging.

alexAubin commented 5 years ago

Yolo then o/