search

YunoHost-Apps / ihatemoney_ynh

Ihatemoney package for YunoHost
Other
9 stars 6 forks source link

Improve README #35

Closed ericgaspar closed 4 years ago

ericgaspar commented 4 years ago
ericgaspar commented 4 years ago

@JocelynDelalande Thanks for reviewing this PR. Empty placeholder make sense because they show contributors what needs to be completed cf README_fr, doc, etc.

JocelynDelalande commented 4 years ago

@JocelynDelalande Thanks for reviewing this PR. Empty placeholder make sense because they show contributors what needs to be completed cf README_fr, doc, etc.

I disagree, bugtracker is the place to track the changes to be done, documentation is not. Main target of this doc is users. (people wishing to install), not contributors.

On a more general tone, sorry for long silence, and thanks for your work. I am still open for discussion, see my comments.

We do disagree on some points on which I won't change my mind (role of documentation, and what can be discussed on this PR). So I'd understand if you think it would be too far from your intent to modify your contribution (maybe that is why you closed ?). But if not feel free to amend re-open and amend your PR.

In all cases, your contribution effort is appreciated <3.