Full revamp of ihatemoney_ynh

[Salamandar]

• [x] Use "standard" variable replacements
• [x] Use systemd
• [x] Fix the upgrade from /opt directory
• [x] implement change_url (should not be very hard)
• [x] Change some paths (socket path mostly) to allow multiple installs
• [ ] Check that the logs are correctly written

[Salamandar]

!testme

[yunohost-bot]

Fingers crossed!

[Salamandar]

@JocelynDelalande it's fully working now !

[klorydryk]

Nice work !

[Salamandar]

Ah yes, this "CSRF token" error... I've had that with the current package some months ago. Going into private browsing fixed the issue, but clearing cache/cookies did not help.

That's clearly not an issue with my pull request, but with ihatemoney itself (or maybe the nginx config ? idk.).

[Salamandar]

@JocelynDelalande The whole venv-old backup style is not needed anymore, since Yunohost already provides a backup/restore system (and the app is backed up before upgrading, and restored on failure).

The whole venv update though, i'm working on it.

[Salamandar]

!testme (yeah, went from virtualenv to venv, checking is required)

[yunohost-bot]

Meow :cat2:

[alexAubin]

21676 INFO DEBUG - + eval 'pip install --upgrade pip setuptools>=18.5 gunicorn>=19.3.0 PyMySQL>=0.9,<0.10 SQLAlchemy<1.4 ihatemoney>=4,<5'
21677 INFO DEBUG - ++ pip install --upgrade pip setuptools gunicorn PyMySQL SQLAlchemy ihatemoney
21677 INFO WARNING - _common.sh: line 38: 0.10: No such file or directory

Lolz it looks like it interprets the >= and <0.10 as file redirects...

[Salamandar]

!testme

[yunohost-bot]

Alrighty!

[Salamandar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[Salamandar]

@JocelynDelalande It's finally working and all your comments have been addressed :)

[JocelynDelalande]

@Salamandar you rocks <3 . Reviewing.

btw, I do agree with all @alexAubin suggestions, and you ? I let you approve them if so.

[JocelynDelalande]

venv-old

@JocelynDelalande The whole venv-old backup style is not needed anymore, since Yunohost already provides a backup/restore system (and the app is backed up before upgrading, and restored on failure).

fair enough.

[Salamandar]

btw, I do agree with all @alexAubin suggestions, and you ? I let you approve them if so.

Yes, I'm on it :)

[Salamandar]

!testme

[yunohost-bot]

:rocket:

[Salamandar]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[JocelynDelalande]

@Salamandar current status in my brain : waiting for you to fix upgrade and change_url to merge. OK for you ?

(Maybe ruling the obvious, but I want to be sure we are not waiting for each other pointlessly :p)

(once that will be merged, I'll upgrade pkg to latest ihatemoney version that was released couple of days ago #42 )

[Salamandar]

@JocelynDelalande yeah don't worry. Also, I would need some help from @alexAubin about the failure during the upgrade. Can't understand the log AT ALL.

[Salamandar]

!testme for the upgrade !

[yunohost-bot]

:rocket:

[Salamandar]

!testme

Oops @JocelynDelalande I re-requested review, missclick.

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[Salamandar]

!testme

I removed the "backup before upgrade" to workaround the yunohost log issue.

[yunohost-bot]

:carousel_horse:

[Salamandar]

!testme

Should be good now !!

[yunohost-bot]

:rocket:

[Salamandar]

FINALLY ! @JocelynDelalande it's working !

[alexAubin]

[brimwats1]

this might not have been right, but I really wanted to try IHM, and it failed when I installed so I tried installing this testing branch and it also failed (error 503). Probably more likely I did something wrong but I thought I'd offer my installation and removal logs

https://paste.yunohost.org/raw/ziholazone

https://paste.yunohost.org/raw/etabobajow

[brimwats1]

looks like it's still pending @JocelynDelalande :)

[ericgaspar]

hey! shouldn't we merge this?

Edit: I get this error at install yunohost: error: unrecognized arguments: --log_type=systemd

[Salamandar]

@ericgaspar is this a new change ? I didn't have those errors.

[Salamandar]

@ericgaspar Still waiting on @JocelynDelalande . Is he OK ? 😞

[ericgaspar]

Let's try to push this PR forward as the master branch is failing tests