search

YunoHost-Apps / invidious_ynh

Invidious package for YunoHost
https://invidio.us/
GNU General Public License v3.0
20 stars 8 forks source link

Thumbnails not showing in external clients #132

Open jazzsnobeatcake opened 1 year ago

jazzsnobeatcake commented 1 year ago

Describe the bug

External clients such as Clipious or this Kodi addon currently cannot load thumbnails via the API if Invidious webclient is protected by SSOwat.

These clients work as expected if the Invidious webclient is accessible to visitors.

Context

Running the latest versions of YNH and the Invidious app on a VPS . The Invidious webclient is only accessible behind SSOwat, the API allows access by and returns data to unregistered visitors. host and external_port are set to "host.tld" and "443" in /var/www/invidious/config/config.yml.

Steps to reproduce

Open incognito window Go to https://host.tld/api/v1/videos/dQw4w9WgXcQ (or any other video ID) API returns results without asking for a SSOwat login Try to open one of the thumbnail URIs, i.e. "https://host.tld/vi/dQw4w9WgXcQ/maxres.jpg" You are now looking at the SSOwat login page instead of the video thumbnail

Expected behavior

Thumbnail should load without getting redirected to SSOwat login page

Possible solution

Make https://**host.tld/vi*/ follow the configuration for https://**host.tld/api/v1**

ericgaspar commented 1 year ago

If you are willing to test a possible fix -> sudo yunohost app upgrade invidious -u https://github.com/YunoHost-Apps/invidious_ynh/tree/Thumbnails

jazzsnobeatcake commented 1 year ago

Thanks! Got around to it just now and running it returned 

Error: Corrupted TOML read from /var/cache/yunohost/app_tmp_work_dirs/app_8v5h525v/manifest.toml (reason: Duplicate keys! (line 63 column 1 char 1521))
ericgaspar commented 1 year ago

sorry, my mistake. can you retry?

jazzsnobeatcake commented 1 year ago

Upgrading worked and it fixed the issue. Clipious is now loading thumbnails!