search

YunoHost-Apps / invoiceninja5_ynh

InvoiceNinja5 package for YunoHost
https://www.invoiceninja.org/
GNU General Public License v3.0
12 stars 7 forks source link

Smtp mail #190

Closed ericgaspar closed 10 months ago

ericgaspar commented 10 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 10 months ago

!testme

yunohost-bot commented 10 months ago

May the CI gods be with you! Test Badge

daniel-fahey commented 10 months ago

@ericgaspar Personally, I'm happy as-is using sendmail, and don't want e.g. invoiceninja5@maindomain.co as the "from" address (MAIL_FROM_ADDRESS='__APP__@__DOMAIN__'.)

Because .env gets remade during upgrade, if users want to keep customisations to their mail configuration, maybe it would be better to use more __VARIABLE__s in default.env for when ynh_add_config() uses ynh_replace_vars(). I think they could then be set after installing with:

$ sudo yunohost app setting invoiceninja5 variable --value "Whatever I want"

Or maybe it would be better to not recreate the modified .env during upgrade? There's also this feature for individual mail configurations per company upstream. I would also like it if the email settings (/settings/email_settings) on the InvoiceNinja web app overrode the .env vars?