search

YunoHost-Apps / jellyfin_ynh

Jellyfin package for YunoHost
https://jellyfin.org/
GNU General Public License v3.0
26 stars 24 forks source link

[autopatch] TEST BEFORE MERGE ynh_setup_source --full_replace=1 #151

Closed Salamandar closed 1 month ago

Salamandar commented 6 months ago

This is an automatic PR

This is an automated patch to potentially fix a bug in the upgrade script.

ynh_setup_source doesn't overwrite the destination directory, but rather extracts the source in the existing directory.

This might lead to weird cases where legacy source files aren't deleted.

The command has an argument --full_replace=1 that fixes this behaviour.

BE CAREFUL because this change might lead to data losses! You should check that all the patches calls to ynh_setup_source do exactly what you expect to do and don't delete user data.

If you want exclude some files from being overwritten/deleted, use the --keep argument, just like that:

ynh_setup_source --dest_dir="$install_dir" --full_replace=1 --keep="config/config.yaml"
Salamandar commented 6 months ago

I guess that is relevant here, what do you think @tituspijean ? I think the jellyfin deb package won't empty the directory on upgrade, so we need to ensure we wipe all the files from the previous ldap plugin version.

tituspijean commented 6 months ago

Tried on my instance. It does work, but the upgrade complains of a "manually modified" configuration file for LDAP. It looks like the plugin stores information on users and libraries. It is updated upon next login, so nothing is really lost. We should not store its checksum.

https://paste.yunohost.org/raw/xoneyagibu

image

Salamandar commented 5 months ago

Hmmm that’s weird indeed :o

Salamandar commented 1 month ago

Well hum @selfhoster1312 already merged that, so closing :D