Update URLs to point to new file locations.

cselti commented 3 months ago

Add requirements.txt. Compute sha256 checksum for ldap plugin zip

Problem

The package repository url changed
I think the #146 has the same issue

Solution

Update the links to point the proper repo url

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

tituspijean commented 2 months ago

!testme !bookwormtestme

yunohost-bot commented 2 months ago

:rocket:

yunohost-bot commented 2 months ago

:book:

cselti commented 2 months ago

@tituspijean - the upgrade error occurs because older versions can no longer be installed anymore. You can test this with any URL in the manifest.toml. For example:

https://repo.jellyfin.org/releases/server/debian/versions/jellyfin-ffmpeg/6.0.1-3/jellyfin-ffmpeg6_6.0.1-3-bullseye_armhf.deb

This URL redirects to https://repo.jellyfin.org/deprecated with the following message:

Deprecated path! This path is no longer valid on our repository server. Please see the repository browser at https://repo.jellyfin.org to find a new path to your desired resource.

Details from the package_check logs

``` bash Working time for this test: 2 minutes, 22 seconds (15:55:30 UTC) ============================================ [Test 7/8] Upgrade from 10.8.0_ynh1 ============================================ > Preliminary install... /tmp/package_check.XRJFVF/app_folder ~/package_check ~/package_check > Running pre-install steps WARNING: apt does not have a stable CLI interface. Use with caution in scripts. Running: yunohost app install --no-remove-on-failure --force /app_folder -a "&domain=sub.domain.tld&admin=package_checker&path=/jellyfin&is_public=true&discovery=true" 2171 INFO Installing jellyfin… 3207 INFO [....................] > Validating installation parameters... 3974 INFO [+...................] > Storing installation settings... 4851 INFO [#+..................] > Finding an available port... 5077 INFO [##+.................] > Configuring firewall... 7385 INFO [###+++..............] > Installing dependencies... 32103 INFO [######..............] > Installing packages... [.4 minutes] 33743 WARNING https://repo.jellyfin.org/deprecated: 33744 WARNING 2024-06-12 15:56:41 ERROR 410: Gone. 35249 ERROR Unable to install jellyfin: An error occurred inside the app installation script 35249 INFO The operation 'Install the 'jellyfin' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20240612-155610-app_install-jellyfin' to get help 35279 WARNING Here's an extract of the logs before the crash. It might help debugging the error: 35280 INFO DEBUG - + [[ false != \f\a\l\s\e ]] 35280 INFO DEBUG - + local local_src=/opt/yunohost-apps-src/jellyfin/ffmpeg.bullseye.amd64 35280 INFO DEBUG - ++ dirname /var/cache/yunohost/download/jellyfin/ffmpeg.bullseye.amd64 35280 INFO DEBUG - + mkdir -p /var/cache/yunohost/download/jellyfin 35280 INFO DEBUG - + src_filename=/var/cache/yunohost/download/jellyfin/ffmpeg.bullseye.amd64 35280 INFO DEBUG - + '[' deb = docker ']' 35280 INFO DEBUG - + test -e /opt/yunohost-apps-src/jellyfin/ffmpeg.bullseye.amd64 35280 INFO DEBUG - + '[' -n https://repo.jellyfin.org/releases/server/debian/versions/jellyfin-ffmpeg/5.0.1-5/jellyfin-ffmpeg5_5.0.1-5-bullseye_amd64.deb ']' 35280 INFO DEBUG - + '[' -e /var/cache/yunohost/download/jellyfin/ffmpeg.bullseye.amd64 ']' 35280 INFO DEBUG - + '[' '!' -e /var/cache/yunohost/download/jellyfin/ffmpeg.bullseye.amd64 ']' 35280 INFO DEBUG - ++ wget --tries 3 --no-dns-cache --timeout 900 --no-verbose --output-document=/var/cache/yunohost/download/jellyfin/ffmpeg.bullseye.amd64 https://repo.jellyfin.org/releases/server/debian/versions/jellyfin-ffmpeg/5.0.1-5/jellyfin-ffmpeg5_5.0.1-5-bullseye_amd64.deb 35281 INFO DEBUG - + out='https://repo.jellyfin.org/deprecated: 35281 INFO DEBUG - 2024-06-12 15:56:41 ERROR 410: Gone.' 35281 INFO DEBUG - + ynh_die '--message=https://repo.jellyfin.org/deprecated: 35281 INFO DEBUG - 2024-06-12 15:56:41 ERROR 410: Gone.' 35281 INFO DEBUG - 2024-06-12 15:56:41 ERROR 410: Gone.' 35282 INFO DEBUG - 2024-06-12 15:56:41 ERROR 410: Gone.' 35282 INFO WARNING - https://repo.jellyfin.org/deprecated: 35282 INFO WARNING - 2024-06-12 15:56:41 ERROR 410: Gone. 35282 INFO DEBUG - + ynh_exit_properly 35304 ERROR The installation of jellyfin failed, but was not cleaned up as requested by --no-remove-on-failure. ```