search

YunoHost-Apps / jenkins_ynh

Jenkins package for YunoHost
https://jenkins.io/
Apache License 2.0
5 stars 10 forks source link

Replace deprecated plugins during installation #118

Closed CodeShakingSheep closed 1 year ago

CodeShakingSheep commented 1 year ago

Describe the feature request

When doing a fresh install the two following deprecated plugins are being installed:

Both plugins provide replacement plugins on the Jenkins pages.

I suggest replacing the two deprecated plugins with the replacement plugins during installation.

Expected behavior

Only actively maintained plugins should be installed by default.

yalh76 commented 1 year ago

As far as I see those plugins are not directly installed during Jenkins install: https://github.com/YunoHost-Apps/jenkins_ynh/blob/ae7daa6297953260aa8cde835916fd346107841c/scripts/install#L150-L185

so they should be installed as a dependency of another plugin. Feel free to do a PR if you find a way to solve that

CodeShakingSheep commented 1 year ago

GitHub Organization Folder Plugin is directly installed. See l.176 $jenkins_plugin_manager --plugins github-organization-folder # GitHub Organization Folder Plugin. I already created a draft PR for this https://github.com/YunoHost-Apps/jenkins_ynh/pull/122.

However, Pipeline: Deprecated Groovy Libraries seems to be a dependency of another plugin. I will check this in the upcoming weeks when I find the time and complete the PR.

CodeShakingSheep commented 1 year ago

Regarding the deprecated Groovy plugin: I could only find Pipeline plugin which has Pipeline Groovy Lib as dependency (but the current one not the deprecated one). So, I'm not sure where the deprecated Groovy plugin is installed.

Also, no plugins are installed which are not suggested by Jenkins (except Subversion which looks ok). I checked the list in the Jenkins repo. So, it's quite a mystery to me where the deprecated Groovy plugin comes from.

CodeShakingSheep commented 1 year ago

Regarding the deprecated Groovy plugin: I could only find Pipeline plugin which has Pipeline Groovy Lib as dependency (but the current one not the deprecated one). So, I'm not sure where the deprecated Groovy plugin is installed.

Also, no plugins are installed which are not suggested by Jenkins (except Subversion which looks ok). I checked the list in the Jenkins repo. So, it's quite a mystery to me where the deprecated Groovy plugin comes from.

I could just solve the mystery. :-D It's used in the deprecated GitHub organization folder plugin, see here. So, I'll mark the PR as ready for review.