add max memory for vm configuration

[rosbeef]

to set max memory usage

Problem

on small memory SBC default java VM memory alocation is too much "3072mb" this result in jvb and jicofo fails to start

Solution

set VIDEOBRIDGE_MAX_MEMORY and JICOFO_MAX_MEMORY in respective config file depends on estimated max user using bridge at a time

PR Status

• [x] Code finished and ready to be reviewed/tested
  • [x] install (manifest + script)
  • [x] update (script)
  • [x] restore (script)
  • [x] config (toml + script)
• [x] The fix/enhancement were manually tested (if applicable)
  • [x] install (manifest + script)
  • [x] update (script)
  • [x] restore (script)
  • [x] config (toml + script)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[rosbeef]

done tested working

[rosbeef]

!testme

[rosbeef]

! only install script is done

[yalh76]

Great work. As you ask for the maxmembers during install, wouldn't it be better to also ask for the maxmembers in the config panel ? to have more consistent questions ? And having a personal helper in _common.sh to calculate the max_memory ? maybe able to check the actual memory size and adapt the maxmembers

[rosbeef]

maybe you have right and only max memory is better, admin should know how much memory he have on his server

[rosbeef]

maybe you can help me config fail but doesn't indicates were is the error: https://paste.yunohost.org/raw/sopadaduqe

[yalh76]

I haven't used config panel fro now, but all I see in your log is: L7 error: Unknown service '' but I don't know what service, it's looking for ...

[rosbeef]

@yalh76 All done! Can be tested even in your config if you want to free memory ;) now let me understand why ports appear as not open in dagnosis

[yalh76]

now let me understand why ports appear as not open in dagnosis

the port is open but nothing is responding until first meeting is launched ^^

[rosbeef]

ok, how to merge my modification in testing now ? sorry i'm noob in contributing :P

[yalh76]

I will check if there is a way to test the config panel

[yalh76]

I've made two draft PR:

• https://github.com/rosbeef/jitsi_ynh/pull/1 : to have a more simple process to define the max memory
• https://github.com/rosbeef/jitsi_ynh/pull/2 : to let user set the maximum users, maximum handled users is calculated from the available memory ...

Let me know what you think of that.

[rosbeef]

thanks yalh you did all well simpler than what i could. i learn ;)

I think max memory is the best way : 1rst configurate max memory is better because we are talking about memory. 2nd Maybe max users could be needed for a parameter that i have not the knowlege. 3rd talking about users to configure memory should be source of misundertanding because some admin maybe want to host lots of simultaneous users but don't know that will require all of his memory.

after, in other PR we could inform that 10% of available memory should permit to host meeting for N simultaneous users (all meetings included).

[rosbeef]

i don't know if i did well to merge. it was like a back flip in forks, I'm a bit lost now what to do ?

[yalh76]

i don't know if i did well to merge. it was like a back flip in forks, I'm a bit lost now what to do ?

merged in testing and in master after a full package_check

[tio-trom]

How will this affect current Jitsi installations? I have plenty of RAM and I'd like it to use as much as possible. Is this new push a limitation? If so how to remove it or increase it? Thanks!

[rosbeef]

Yes You can increase memory in config panel. Default is 75mb, One simultaneous user un the instance use around 1,5 mb ram . with 1000 simultaneous users it never used more than 1500mb ram. https://YOURDOMAIN/yunohost/admin/#/apps/jitsi/config-panel

[tio-trom]

Awesome. So easy! Thanks a lot!