YunoHost-Apps / kimai2_ynh

Kimai v2 package for YunoHost
https://www.kimai.org/
MIT License
13 stars 8 forks source link

[buster] Adapt the PHP 7.x custom install / requirement #22

Closed alexAubin closed 4 years ago

alexAubin commented 4 years ago

Following the discussion started here, this app needs to be adapted both to :

Currently the app relies on a custom install of PHP 7.1 / 7.2 / 7.3 which should be adapted. Imho (to be discussed and see with other app packagers after we gain more XP with this) :

Overall this treatment should be pretty much the same for all apps in that situation, so once we solve this for one app it should be easily applicable to other similar apps.

kevinpapst commented 4 years ago

@alexAubin I think we need to find a maintainer for this repo first. Are you the right person to talk to when it comes to repository permissions? I find it highly annoying, that nobody takes care of the package, which gives a very bad impression of Kimai. Not that I want to become the maintainer of this repo, but I could have a look for problems here and there (as I am the developer of Kimai).

anmol26s commented 4 years ago

@kevinpapst Sorry for not maintaining the repo. I was little busy. I will rework on the repo and try to update it. Will need your help on it too.

kevinpapst commented 4 years ago

@anmol26s oh hey, there your are 😄 I don't blame you at all. You did a great job when integrating it the first time and I am thankful for it!

Its just the fact that the app integration should be a win-win for both sides. And the current situation is more like a loose-loose situation, both for Kimai and for YunoHost. Having a broken/outdated app is frustrating for YunoHost users.

And I have no clue how to reach someone that could pass on permissions to me, "just in case". As said: I don't really have time for being a maintainer here, but it would be good to know that in case of an emergency/critical bug or something similar I would be able to jump in.

yalh76 commented 4 years ago

Well I've made a PR to upgrade the package to Kimai2 1.8 from https://github.com/kevinpapst/kimai2/releases/download/1.8/kimai-release-1.8.zip + PHP7.3. But for now, I've an error 500 and I can't figure what is missing....

image

Did I need to execute composer even when using the .zip release file ?

kevinpapst commented 4 years ago

No, executing composer shouldn't be necessary. Are you sure that the file permissions are correct? Anything in var/log/prod.log?