Fix Buster

[yalh76]

• Fix #22

• Fix #20

• Fix #18

• Fix #17

• Fix #13

• Apply example_ynh

• Upgrade to 1.8

• Upgrade to PHP7.3

• Implementing ldap and Kimai2 roles based on YunoHost permissions

Package_check results

---

Revision: 93968e7326d7aa1d6361437ed061a5b4a0ce9829

Stretch:

Buster:

[kevinpapst]

Any chance you can use the GIT installation? If it works: great! But I don't support the FTP installation and for long term support git should be preferred.

[yalh76]

Any chance you can use the GIT installation? If it works: great! But I don't support the FTP installation and for long term support git should be preferred.

I switched to the git version

[yalh76]

Seems OK, if someone want to test it.

[kevinpapst]

By "installing the git version" I actually meant using git clone and not the git release archive. I never used YunoHost, so I don't know if that is feasible.

Thanks for all your work you put into this installation and for supporting Kimai 👍 Very much appreciated!!!!!

[yalh76]

By "installing the git version" I actually meant using git clone and not the git release archive. I never used YunoHost, so I don't know if that is feasible.

Thanks for all your work you put into this installation and for supporting Kimai 👍 Very much appreciated!!!!!

We can use git clone but YunoHost packages usually use .tar.gz archive:

• it allows to have a checksum on the .tar.gz to be sure there is no corruptions during transfer of the source: https://github.com/YunoHost-Apps/kimai2_ynh/blob/16c3f101526ee6c3b1df0a93db6e4ab62db45212/conf/app.src#L1-L4
• it makes the full backup smaller (without the .git folder)

[kevinpapst]

I am just afraid, that I might move files around in Kimai and these old files won't get deleted during an updated. Thats why I recommend git, because git would take care of deleting these old files.

But if you delete the complete application before the update, this problem should not occur.

[yalh76]

I am just afraid, that I might move files around in Kimai and these old files won't get deleted during an updated. Thats why I recommend git, because git would take care of deleting these old files.

But if you delete the complete application before the update, this problem should not occur.

Thanks, I didn't reread that part of the code, now after saving in a tempdir some files:

• /config/packages/local.yaml
• /var/invoices
• /var/data It purge the Kimai2 files and download/extract the new sources and then restore previous saved files

https://github.com/YunoHost-Apps/kimai2_ynh/blob/d44cfc271a7f8975ec87cc6e005eccb2a09e2a28/scripts/upgrade#L96-L129

[kevinpapst]

This is much better!

Just found one more thing. Can you add -n to php7.3 bin/console kimai:update so it becomes:

php7.3 bin/console kimai:update -n

Just in case there will ever be interactive questions added to the update mechanism, this flag will prevent the update from being interrupted, instead the default answer will be used.

[yalh76]

php7.3 bin/console kimai:update -n

Updated ;)

[kevinpapst]

Great work! I am installing a Virtualbox image for YunoHost, lets see if I can test this... I might come back with a couple of questions as I never used it before.

[SiM]

Hello,

Any chance this PR will be merged soon ?

[yalh76]

Hello,

Any chance this PR will be merged soon ?

not that soon, I just worked to make it YunoHost 3.8 ready and have to wait for a package_check