search

YunoHost-Apps / kimai2_ynh

Kimai v2 package for YunoHost
https://www.kimai.org/
MIT License
13 stars 8 forks source link

Updated to v1.14.3 #37

Closed anmol26s closed 2 years ago

anmol26s commented 3 years ago

Problem

Solution

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

Meow :cat2: Test Badge

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket: Test Badge

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:stuck_out_tongue_winking_eye: Test Badge

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:stuck_out_tongue_winking_eye: Test Badge

anmol26s commented 3 years ago

Migration from sqlite to mysql is not managed

Sqlite is now not supported by app. I don't know how to migrate from sqlite to mysql. Even if we do it I don't know if that would work. Maybe @kevinpapst can elaborate on, how to migrate existing Sqlite database to Mysql.

Why doing a partial switch of source to git ? Doing that we don't know which Kimai2 version will be installed ...

It's only for new installations. I don't know if its good idea to bring everyone to git.If you recommend we can try to move everyone to git. I did not do it because I don't have live running Kimai2 app. So there is no way to test that this would not break anything in while we migrate to git. We can always check the git tag to test the version of installed app. We can give option to use git or not to use it, while installation if installing with git is not OK with you.

kevinpapst commented 3 years ago

There is a Ruby script which works: https://www.kimai.org/blog/2021/sqlite-and-ftp-support-removed/ But I would rather disallow migration from SQLite and show an explanation - doing the migration automatically would be great but feels a bit risky.

anmol26s commented 3 years ago

That would be lot of work and extra effort to migrate from Sql to Mysql. I don't know if its worth to make that much changes. So,

  1. We can check if the database is Sqlite. We can stop the upgrade process with an error message that Sqlite is not supported anymore. This is like saying that game ends here, start over again. I don't think there would many users on Sqlite, when you have option for mysql from day 1.
  2. Or we can try to force migrate everyone to mysql with above method.

We can have a poll on Yuno to see if there are potential users that needs to migrated to Mysql.

yalh76 commented 3 years ago

Why doing a partial switch of source to git ? Doing that we don't know which Kimai2 version will be installed ...

It's only for new installations. I don't know if its good idea to bring everyone to git.If you recommend we can try to move everyone to git. I did not do it because I don't have live running Kimai2 app. So there is no way to test that this would not break anything in while we migrate to git. We can always check the git tag to test the version of installed app. We can give option to use git or not to use it, while installation if installing with git is not OK with you.

If you think that moving everyone to git is not a good idea, better to let all with app.src. But having to maintain two different source system will be difficult The point is there two options for me:

  1. using app.src:
    • Pro: each new installation install a precise version of the upstream app
    • Cons: if upstream app provide a new version, package must be updated
  2. using git
    • Pro: package is always up to date with the upstream app
    • Cons: each new installation can install an unknown new version, with new unmet requirements... Install may fail...
kevinpapst commented 3 years ago

As being "the upstream" 😁 I can tell that the only requirements that changed in the last 1,5 years was:

yalh76 commented 3 years ago

As being "the upstream" 😁 I can tell that the only requirements that changed in the last 1,5 years was:

* the drop of SQLITE (which was always announced as being for test only, not production - my mistake that I didn't see it here earlier)

* the change of minimum PHP version (being 7.2.9 now and the next version bumps it to PHP 7.3). So rather conservative as 7.2 support ended half a year ago and I guess YunoHost is more up-to-date?

It was a more general comment, not relative to Kimai ^^ because @anmol26s made several PR on several apps to switch them to git...

And Yes YunoHost PHP version is 7.3

And the question is: Do we prefer to have some packages to be late from the upstream app or do we prefer some of them having installation fail suddenly...

kevinpapst commented 3 years ago

Ok, I silence myself 😁 this sounds like a general question that needs to be answered somewhere else.

yalh76 commented 3 years ago

Ok, I silence myself 😁 this sounds like a general question that needs to be answered somewhere else.

Sorry, it was in Kimai upgrade but I made a more general statement ^^

anmol26s commented 3 years ago

Git: Its more easy to change ecosystems.

Cons: each new installation can install an unknown new version, with new unmet requirements... Install may fail...

We can still use tags to force the package to stay on a particular version.

yalh76 commented 3 years ago

Git: Its more easy to change ecosystems.

Cons: each new installation can install an unknown new version, with new unmet requirements... Install may fail...

We can still use tags to force the package to stay on a particular version.

Good point using tags to specify the version to install and having previous app.src install moving to git source + manage the end of sqlite ^^

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:rocket: Test Badge

anmol26s commented 3 years ago

Do we need to migrate the sqlite to mysql? I think its better to give an error message and stop the upgrade if the instance is on sqlite.

anmol26s commented 3 years ago

Ok, no more option to force update. @yalh76

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

Fingers crossed! Test Badge

anmol26s commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:sunflower: Test Badge