search

YunoHost-Apps / kresus_ynh

Kresus (personal finance manager) for YunoHost
https://kresus.org/
GNU Affero General Public License v3.0
20 stars 20 forks source link

[autopatch] TEST BEFORE MERGE ynh_setup_source --full_replace=1 #185

Open Salamandar opened 8 months ago

Salamandar commented 8 months ago

This is an automatic PR

This is an automated patch to potentially fix a bug in the upgrade script.

ynh_setup_source doesn't overwrite the destination directory, but rather extracts the source in the existing directory.

This might lead to weird cases where legacy source files aren't deleted.

The command has an argument --full_replace=1 that fixes this behaviour.

BE CAREFUL because this change might lead to data losses! You should check that all the patches calls to ynh_setup_source do exactly what you expect to do and don't delete user data.

If you want exclude some files from being overwritten/deleted, use the --keep argument, just like that:

ynh_setup_source --dest_dir="$install_dir" --full_replace=1 --keep="config/config.yaml"
nicofrand commented 8 months ago

This might lead to weird cases where legacy source files aren't deleted.

I remember it did indeed. See https://github.com/YunoHost-Apps/kresus_ynh/commit/2e00fbf488f2adffeda718ff69c03842abbf6475 This was removed in https://github.com/YunoHost-Apps/kresus_ynh/commit/2c288cc27992815f2665f93bae64ae7f4f7866bf#diff-57aeb84da86cb7420dfedd8e49bc644fb799d5413d01927a0417bde753e8922f :/

So, this MR is probably useful indeed.