Install the pdfminer module by default

YunoHost-Apps / kresus_ynh

Kresus (personal finance manager) for YunoHost

https://kresus.org/

GNU Affero General Public License v3.0

20 stars 20 forks source link

Install the pdfminer module by default #47

Closed bnjbvr closed 4 years ago

bnjbvr commented 4 years ago

... so weboob can use it to parse PDFs. Not sure it's actually necessary, but it's nice to have as a bonus feature.

lenod commented 4 years ago

I reckon this changed made my last kresus upgrade fail with: ERROR: Package 'pdfminer' requires a different Python: 3.5.3 not in '>=3.6'

Indeed, python3 has version 3.5.3 on debian stretch, and yunohost doesn't support debian buster yet. Maybe consider allowing the installation of pdfminer to fail?

Jibec commented 4 years ago

Benjamin, what do you think?

nicofrand commented 4 years ago

Hi!

Just seeing this issue… I thought pdfminer.six was the one compatible with python3 anyway?

bnjbvr commented 4 years ago

Oops, yeah might be necessary to replace it by pdfminer.six then, sorry about this!