YunoHost-Apps / lufi_ynh

Lufi package for YunoHost
https://framagit.org/fiat-tux/hat-softwares/lufi
GNU General Public License v3.0
16 stars 8 forks source link

Allow LDAP on public and remove legacy permission and various fixes #69

Closed tytan652 closed 2 years ago

tytan652 commented 2 years ago

Problem

Closes #68

I wanted to allow installing Luti with LDAP with public visibility and remove legacy permission.

Solution

Other changes

PR Status

summary

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you! Test Badge

tytan652 commented 2 years ago

I was actually rebasing but you fix the conflicts.

Note: Tabs have to be replaced by spaces in new lines of the manifest.json if needed.

yalh76 commented 2 years ago

I was actually rebasing but you fix the conflicts.

Yes, as I've done few modifications without checking your PR, I'd prefer to fix the mess

Note: Tabs have to be replaced by spaces in new lines of the manifest.json if needed. I've seen that and done it :)

Just have to wait for the package_check and we will merge it in testing