YunoHost-Apps / lutim_ynh

Lutim package for YunoHost
https://lut.im
GNU General Public License v3.0
5 stars 7 forks source link

Uploaded images are locked behind SSO #80

Open MrTastyBiscuits opened 1 month ago

MrTastyBiscuits commented 1 month ago

Describe the bug

When installing, I have set my Lutim instance to be accessible to YNH users only. Despite that, shared images should be accessible by everybody as described here : https://github.com/YunoHost-Apps/lutim_ynh/blob/319b7620e0a5749ca6aeee27fbd7e93eaae9ad5d/manifest.toml#L38 It is not the case, shared images are locked behind the SSO.

Context

Steps to reproduce

  1. Install Lutim from the webadmin
  2. Select a domain and install at its root
  3. Choose to make the app limited to YNH users
  4. Leave "Encrypt images" ticked (default)
  5. Click install
  6. Wait for quite some time
  7. Access Lutim, upload an image and copy link
  8. Open link in private window of browser
  9. Get stuck on the SSO without seeing the image

Expected behavior

It is described here: https://github.com/YunoHost-Apps/lutim_ynh/blob/319b7620e0a5749ca6aeee27fbd7e93eaae9ad5d/manifest.toml#L38 Upload should be limited to YNH users while viewing of uploaded images should be available to everybody

Other attemps

I have tried to install the app as public and obviously it is accessible without being logged in. Changing it afterwards to YNH users only leads to the same incorrect behaviour as described in the issue above.

My knowledge of Linux/NGINX is not good enough for me to try to tinker with the config files, that said, I did not find anything in the config files of this repo that would suggest the behaviour described in manifest.toml is actually implemented (but I could be very wrong there).

Either way, thank you for your work on this app (and YNH) and please let me know if there is anything else that I can do.