[enh] Enable SSO - Githubissues

YunoHost-Apps / mastodon_ynh

Free, open-source social network for YunoHost

https://joinmastodon.org/

GNU Affero General Public License v3.0

84 stars 34 forks source link

[enh] Enable SSO #294

Closed Tagadda closed 2 years ago

Tagadda commented 2 years ago

Problem

SSO doesn't work

Solution

Patch Devise config to use http_auth with TwoFactorLdapAuthenticatable
Patch TwoFactorLdapAuthenticatable to accept http_auth (https://github.com/cschiewek/devise_ldap_authenticatable/blob/default/lib/devise_ldap_authenticatable/strategy.rb#L13 https://github.com/heartcombo/devise/blob/main/lib/devise/strategies/authenticatable.rb#L18
Patch after_sign_out redirection to SSO log out page

PR Status

I tested this with domain.tld as main domain and Mastodon installed at mastodon.domain.tld

A known issue : Log-out from YunoHost's portal doesn't log out from Mastodon. See https://github.com/YunoHost/issues/issues/501

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested

Automatic tests