search

YunoHost-Apps / mastodon_ynh

Free, open-source social network for YunoHost
https://joinmastodon.org/
GNU Affero General Public License v3.0
84 stars 34 forks source link

Admin role is capitalized #348

Closed panomaki closed 1 year ago

panomaki commented 1 year ago

Problem

(Automated) install of app fails when creating the mastodon admin user. See issues https://github.com/YunoHost-Apps/mastodon_ynh/issues/344 and https://github.com/YunoHost-Apps/mastodon_ynh/pull/345.

Solution

Fixed install issue (https://github.com/YunoHost-Apps/mastodon_ynh/issues/344/https://github.com/YunoHost-Apps/mastodon_ynh/pull/345) by applying the fix mentioned in this issue: https://github.com/mastodon/mastodon/issues/18813 (change role from admin to Admin).

Tested on local machine, install now works. Please review/test.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

yalh76 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Fingers crossed! Test Badge

neosam commented 1 year ago

This looks promising, right? Is there anything I can do to help?

panomaki commented 1 year ago

This looks promising, right? Is there anything I can do to help?

I think one of the maintainers, such as @yalh76 needs to decide whether the pull request can be accepted. So we just wait.

tituspijean commented 1 year ago

The fix is innocent and documented enough, I take the initiative to merge. :)