search

YunoHost-Apps / mastodon_ynh

Free, open-source social network for YunoHost
https://joinmastodon.org/
GNU Affero General Public License v3.0
84 stars 33 forks source link

Patch Gemfile to fix blurhash and ox packages #360

Closed badrihippo closed 1 year ago

badrihippo commented 1 year ago

Problem

Mastodon wasn't installing (or upgrading) properly because the blurhash package was broken with newer versions of Ruby/gem. This has been described in several issues, including in https://github.com/YunoHost-Apps/mastodon_ynh/issues/357

Additionally, using the fixed version of blurhash created similar errors with ox as described in https://github.com/ohler55/ox/issues/300

Close #357

Solution

Fixes have been made to both blurhash (https://github.com/Gargron/blurhash/pull/20) and ox (https://github.com/ohler55/ox/pull/301). However, these are yet to make it to a new release. To make Mastodon work before that, I've patched Gemfile and Gemfile.lock to install the two packages directly from their respective git repos. (I've locked them to the specific commits of the fixes, so we won't unintentionally add other updates as well).

If this PR is accepted, we should probably leave a note somewhere to remove the patch when newer versions of blurhash and ox come out.

PR Status

Automatic tests

I'm not part of the Yunohost-Apps organisation, so someone with the powers please invoke this :slightly_smiling_face:

yalh76 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:rocket: Test Badge

badrihippo commented 1 year ago

Some of the tests are saying "unable to install mastodon" because mastodon is already installed (or that the domain is already full)!

Is this a CI thing or does something in the code need fixing? :eyes:

Edit: looks like other tests around the same time are affected with the same problem too

yalh76 commented 1 year ago

Some of the tests are saying "unable to install mastodon" because mastodon is already installed (or that the domain is already full)!

Is this a CI thing or does something in the code need fixing? 👀

Edit: looks like other tests around the same time are affected with the same problem too

Yes more a CI dev issue

oufmilo commented 1 year ago

i've launched it on my personnal yunorunner

Test Badge

badrihippo commented 1 year ago

Yay! Thank you :slightly_smiling_face:

I didn't realise yunorunner was a thing, but now I see it even has a yunohost package. Of course it has a yunohost package :stuck_out_tongue:

Warning: the upgrade works but earlier upgrades break; possibly because of version mismatches after the version patch? Not sure if that's a concern...

oufmilo commented 1 year ago

You welcome!

Yes i've seen that. i think it's not a problem and maybe we should remove upgrade from earlier versions

yalh76 commented 1 year ago

Yay! Thank you 🙂

I didn't realise yunorunner was a thing, but now I see it even has a yunohost package. Of course it has a yunohost package 😛

Warning: the upgrade works but earlier upgrades break; possibly because of version mismatches after the version patch? Not sure if that's a concern...

Nope, upgrade from previous versions fails because install of previous version fails

badrihippo commented 1 year ago

Nope, upgrade from previous versions fails because install of previous version fails

Oh of course, I should have thought of that! :facepalm: