YunoHost-Apps / mastodon_ynh

Free, open-source social network for YunoHost
https://joinmastodon.org/
GNU Affero General Public License v3.0
85 stars 36 forks source link

Upgrade to v4.1.2 #378

Closed panomaki closed 1 year ago

panomaki commented 1 year ago

Problem

Solution

This pull request also supersedes #366, #368 and #375.

PR Status

[Manually tested on a Virtualbox installation, both clean install and upgrade from 4.0.2]

Automatic tests

Please trigger automatic tests as I can't.

lapineige commented 1 year ago

!testme

yunohost-bot commented 1 year ago

May the CI gods be with you! Test Badge

lapineige commented 1 year ago

It seems fixed.

panomaki commented 1 year ago

It seems fixed indeed; the tests pass 1 - 5; the install of the ancient 3.5 version fails in 6 so can't be upgraded and 7 times out?

lapineige commented 1 year ago

Why CI says backup&restore fails why the logs say it worked ? 🤔

lapineige commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:v: Test Badge

panomaki commented 1 year ago

It appears the yunohost-runner has problems installing mastodon_3.5.3_ynh1. As that is necessary to test the upgrade, it fails. @yalh76 is there something that can be done here? Is it something in check_process (which should include testing the upgrade from 4.0.2, but anyways an upgrade from 3.5.3 should still be possible, it's less than a year old)?

panomaki commented 1 year ago

Note: Mastodon 4.1.2 is a security patch that solves a vulnerability when using LDAP. As yunohost uses LDAP-authentication for mastodon by default, therefor this upgrade is urgent, but I cannot solve the fact yunohost-runner doesn't run through all tests... anybody able to help?

panomaki commented 1 year ago

Reran job 6613 with the added commits, passes. Changed README to reflect upgrade paths.

lapineige commented 1 year ago

This makes me wonder why the cache in even included in the backup, and not excluded by default.

panomaki commented 1 year ago

This makes me wonder why the cache in even included in the backup, and not excluded by default.

As far as I can see it that is because the yunohost backup system (I presume that this is also used here) does not allow to exclude directories outside /home (and you'd have to exclude /var/www/mastodon/live/public/assets.

lapineige commented 1 year ago

Oh, that's too bad :(

I wonder if it's a planed feature @YunoHost-Apps/apps-group, and/or if we could bypass this by putting date in /home and symlinking them… but depending on how users manage their files this might be an issue…

lapineige commented 1 year ago

So… ready for merging ? :)