YunoHost-Apps / matomo_ynh

Matomo package for YunoHost
https://matomo.org/
GNU General Public License v3.0
18 stars 6 forks source link

Fix linter warnings #97

Closed oufmilo closed 1 year ago

oufmilo commented 1 year ago

Problem

! scripts/install

! It looks like this app requires the admin to finish the install by entering DB credentials. Unless it's absolutely not easily automatizable, this should be handled automatically by the app install script using curl calls, or (CLI tools provided by the upstream maybe ?). 

Solution

Add ynh_send_readme_to_admin__2

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

oufmilo commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse: Test Badge

ericgaspar commented 1 year ago

This PR just seems to bypass the linter warning. I think I will prefer the warning to be addressed so we don't need to send credentials to email. (this will be less problematic with app v2).