search

YunoHost-Apps / matrix-puppet-discord_ynh

GNU Affero General Public License v3.0
4 stars 3 forks source link

update to latest version and fix install #12

Closed jukefr closed 1 year ago

jukefr commented 2 years ago

i'm not sure about all the best practices around ynh so feel free to refactor as required

theres is an important point: there are dependencies required to build the canvas lib, see https://gitlab.com/mx-puppet/discord/mx-puppet-discord#setup

also yarn is pretty much required with how the project is architectured now

i used node 12 because they use it in their own docker image

jukefr commented 2 years ago

also i noticed there is an npm install command that might need to be adjusted to the same in the upgrade file

jukefr commented 2 years ago

i hope the -- install thing works not sure how to test

fflorent commented 2 years ago

There is a CI and I'll do the manual test if you want.

OK for rebasing with testing and squashing your commits into a single one?

jukefr commented 2 years ago

yeah rewrote history to have a single commit and u can merge whenever if its passing :)

fflorent commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:rocket: Test Badge

fflorent commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse: Test Badge

fflorent commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:sunflower: Test Badge

fflorent commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Fingers crossed! Test Badge

fflorent commented 2 years ago

OK, I'll try something else then.

jukefr commented 2 years ago

npx -- yarn install might be the more correct command (instead of npx yarn -- install) do you have any docs anywhere on like spinning up a ynh testing vm locally or something by any chance ? (im running my services on a raspberry pi and its pretty much full on ressources at all times so i have to stop everything if i want to install something and it takes like 30mn-1hour for build processes so its not an ideal testing env :sweat_smile:)

fflorent commented 2 years ago

do you have any docs anywhere on like spinning up a ynh testing vm locally or something by any chance ?

That's partly because of this reason I am so slow to review, I tried to run a lxc instance yesterday, but I failed :/ (it used to work).

If you want to try: https://github.com/YunoHost/ynh-dev

jukefr commented 2 years ago

does seem to work with just npx yarn install weirdly on an aarch64 test machine.... i dont know what happened first time around....

edit: yeah seems to work idk maybe i typoed at some point :sweat_smile: