YunoHost-Apps / mattermost_ynh

Mattermost package for YunoHost
http://www.mattermost.org
GNU General Public License v3.0
33 stars 18 forks source link

Upgrade to Matermost 5.39.0 #280

Closed kemenaran closed 3 years ago

kemenaran commented 3 years ago

CHangelog : https://docs.mattermost.com/install/self-managed-changelog.html#release-v5-39-quality-release

kemenaran commented 3 years ago

!testme

yunohost-bot commented 3 years ago

:carousel_horse: Test Badge

tituspijean commented 3 years ago

⚠️ Somehow the checksums for ARM and ARM64 do not match anymore. (discovered while comparing with #277 outputs)

ericgaspar commented 3 years ago

@tituspijean you mean because of the update script using sha256sum instead of sha512sum used in this PR?

tituspijean commented 3 years ago

@ericgaspar Ooops my bad, indeed I did not notice the kind of checksum being used.

ericgaspar commented 3 years ago

@kemenaran Maybe we can switch back to sha256sum instead of sha512sum for the two GitHub repos?

kemenaran commented 3 years ago

The reason third-party builds use a sha512 for now is that the digests are published along with the releases – so there's no need to download the whole release to re-compute the digest locally.

(But if that bothers maintainers, we can go the "download everything" route anyway, it doesn't matter very much)

ericgaspar commented 3 years ago

With the auto-update mechanism, shasums are generated automatically but we need to homogenize all the shasums to 256.

tituspijean commented 3 years ago

Checksums could be variable. It is a nice thing that upstream publishes the checksums themselves, so that we have another means of verifying the sources are not altered. It's up to you guys, I can come up with an alteration of the update script.

kemenaran commented 3 years ago

@ericgaspar is this fine with you?