dependency signald>=0.15

[Gredin67]

Problem

• Description of why you made this PR
• closes #22
• Somehow fixes #29
• Now closes #31

Solution

• And how do you fix that problem

PR Status

• [ ] Code finished.
• [ ] Tested with Package_check.
• [ ] Fix or enhancement tested.
• [ ] Upgrade from last version tested.
• [ ] Can be reviewed and tested.

Package_check results

---

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

[Gredin67]

!testme

[yunohost-bot]

Fingers crossed!

[MayeulC]

Installing this now works for me, possibly thanks to a recent yunohost upgrade (previously, it did not recognize >15). I would be in favor of merging this. DO you know why the upgrade failed? Can I see the log somehow?

Edit: this won't work, the latest version requires glibc 2.29

[Gredin67]

!testme

I would merge if it passes

[yunohost-bot]

Meow :cat2:

[MayeulC]

No, I was trying this on another branch, and I asked about this in the packaging room a few days ago, it seems like yunohost helpers are very broken.

I'm currently trying to solve this upstream. Other options are: not using yunohost helpers, providing the .deb directly, compiling from source.

Branch I was testing this on: https://github.com/YunoHost-Apps/mautrix_signal_ynh/tree/pin-0.15.0

Question on packaging: https://matrix.to/#/!AgodQnVOpNIYIqBqLP:matrix.org/$16369958690FsRPq:mayeul.net?via=matrix.org&via=libera.chat&via=aria-net.org

Discussed here already: https://github.com/YunoHost-Apps/mautrix_signal_ynh/issues/22#issuecomment-969116048

:)

[Gredin67]

ok I was thinking that the syntax of the version (0.15.0-0-65cf5e8a 0.15.0) could be wrong. I could have tried it in your branch..

If the helper is broken we should repair it. It is probably a small work if the >= version is working properly.

[MayeulC]

!testme

I changed the pinned version, I think it would be a good idea to merge if passing.

[nathanael-h]

Just installed testing branch on my ynh server. Install ok : https://paste.yunohost.org/raw/ecinaruquf Signald service is ko:

● signald.aa - A daemon for interacting with the Signal Private Messenger
   Loaded: loaded (/lib/systemd/system/signald.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Fri 2021-11-26 10:10:02 CET; 4min 21s ago
 Main PID: 22947 (code=exited, status=1/FAILURE)

Nov 26 10:10:02 aa.fr systemd[1]: signald.service: Service RestartSec=100ms expired, scheduling restart.
Nov 26 10:10:02 aa.fr systemd[1]: signald.service: Scheduled restart job, restart counter is at 7.
Nov 26 10:10:02 aa.fr systemd[1]: Stopped A daemon for interacting with the Signal Private Messenger.
Nov 26 10:10:02 aa.fr systemd[1]: signald.service: Start request repeated too quickly.
Nov 26 10:10:02 aa.fr systemd[1]: signald.service: Failed with result 'exit-code'.
Nov 26 10:10:02 aa.fr systemd[1]: Failed to start A daemon for interacting with the Signal Private Messenger.

I have this error in mautrix-signal logs : [2021-11-26 10:20:17,398] [ERROR@mausignald] Connection to /var/run/signald/signald.sock failed: [Errno 2] No such file or directory

And when I send link to the bot I have:

Traceback (most recent call last):
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mautrix/bridge/commands/handler.py", line 409, in handle
    await self._run_handler(handler, evt)
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mautrix/bridge/commands/handler.py", line 296, in __call__
    return await self._handler(evt)
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mautrix_signal/commands/auth.py", line 64, in link
    sess = await evt.bridge.signal.start_link()
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mausignald/signald.py", line 112, in start_link
    return LinkSession.deserialize(await self.request_v1("generate_linking_uri"))
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mausignald/rpc.py", line 221, in request_v1
    return await self.request(command, expected_response=command, version="v1", **data)
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mausignald/rpc.py", line 215, in request
    resp_type, resp_data = await self._raw_request(command, **data)
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mausignald/rpc.py", line 211, in _raw_request
    await self._send_request(data)
  File "/opt/yunohost/mautrix_signal/lib/python3.7/site-packages/mausignald/rpc.py", line 201, in _send_request
    raise NotConnected("Not connected to signald")
mausignald.errors.NotConnected: Not connected to signald

[MayeulC]

Hey @nathanael-h, thanks for reporting. The signald service shouldn't be down, have you tried restarting it manually?

Could you give the version installed with apt list --installed signald?

You can hop on #mautrix_yunohost:matrix.fdn.fr for a quick interactive chat if you want.

[nathanael-h]

Hey, thanks for the packaging, and the quick reply!

here is a few outputs:

root@aa:~# apt list --installed signald
Listing... Done
signald/now 0.15.0-27-88722d97 amd64 [installed,local]
root@aa:~# 

And indeed starting the service with systemctl start signlad seems to work. Sory I didn't try right after installation.

root@aa:~# systemctl status signald
● signald.service - A daemon for interacting with the Signal Private Messenger
   Loaded: loaded (/lib/systemd/system/signald.service; enabled; vendor preset: enabled)
   Active: active (running) since Fri 2021-11-26 11:39:13 CET; 1min 26s ago
 Main PID: 1911 (java)
    Tasks: 24 (limit: 4915)
   Memory: 121.7M
   CGroup: /system.slice/signald.service
           └─1911 java -classpath /var/lib/signald/lib/signald.jar:/var/lib/signald/lib/signal-service-java-x86_64-unknown-linux-gnu-2.15.3_unofficial_34.jar:/var/lib/signald/lib/

Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.128 [main] INFO  io.finn.signald.Main - applied migration 2/8: create core account tables [1 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.128 [main] INFO  io.finn.signald.Main - applied migration 3/8: identity keys table [2 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.129 [main] INFO  io.finn.signald.Main - applied migration 4/8: create sender keys tables [0 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.129 [main] INFO  io.finn.signald.Main - applied migration 5/8: create servers table [1 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.129 [main] INFO  io.finn.signald.Main - applied migration 6/8: update and add server values [2 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.129 [main] INFO  io.finn.signald.Main - applied migration 7/8: create group tables [0 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.129 [main] INFO  io.finn.signald.Main - applied migration 8/8: update zkgroup server public key [0 ms]
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.131 [main] INFO  io.finn.signald.Main - Binding to socket /var/run/signald/signald.sock
Nov 26 11:39:16 aa.fr signald[1911]: 11:39:16.161 [main] INFO  io.finn.signald.Main - Started signald 0.15.0-27-88722d97
Nov 26 11:39:17 aa.fr signald[1911]: 11:39:17.400 [connection-pid-28450] INFO  io.finn.signald.clientprotocol.ClientConnection - Client connected

[MayeulC]

OK, I am not sure why that service wasn't correctly started (a reboot would also have fixed this). Good to know that it installed v0.15.0-27. It should work properly now, I think.

[nathanael-h]

It does work very well, testing could be merge I think :fireworks:

[MayeulC]

Do you think I can merge @Gredin67 ? I don't have access to the CI...

[Gredin67]

I guess so, let's !testme You can ask to join the Yunohost organization, e.g. on the Yunohost Apps Matrix room.

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[MayeulC]

I think the CI failure is fine, with 898c8ffc just failing to install now due to source checksum errors, not much we can do.

I'm going to merge this. Sorry for changing the commiter at some point (though it's such a small commit...).