YunoHost-Apps / mautrix_signal_ynh

Matrix signal package for YunoHost
GNU Affero General Public License v3.0
4 stars 10 forks source link

Expose more settings #33

Closed nathanael-h closed 2 years ago

nathanael-h commented 2 years ago

Enhancement

PR Status

Package_check results


If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

Build Status

MayeulC commented 2 years ago

Looks promising, though we might want to adjust the text:

!signal set-relay

Wouldn't that be !sg set-relay?

nathanael-h commented 2 years ago

Thanks for your review :smiley:

Gredin67 commented 2 years ago

rather solve #24

yalh76 commented 2 years ago

Instead of exposing more settings during install, that will slow down the installation process, it would be more user friendly to use config panel, letting the admin change those parameters at any time :)

nathanael-h commented 2 years ago

I am okay with that. I don't know yet how the new config panel works. Maybe soon.

Nathanaël decouvrir-dieu.com isidorus.fr Cloud dégooglisé pour la famille et les amis

4 févr. 2022 03:00:40 yalh76 @.***>:

Instead of exposing more settings during install, that will slow down the installation process, it would be more user friendly to use config panel, letting the admin change those parameters at any time :)

— Reply to this email directly, view it on GitHub[https://github.com/YunoHost-Apps/mautrix_signal_ynh/pull/33#issuecomment-1029570186], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABXWJVOUIOBSFVDDCHCQ3Y3UZMXMNANCNFSM5JR5RIHQ]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you authored the thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEEAAABBCAYAAACO98lFAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAnSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAALg3QkUAAR85m+QAAAAASUVORK5CYII=###24x24:true###][Image de pistage][https://github.com/notifications/beacon/ABXWJVOD3VNXMP2CYFZCY6LUZMXMNA5CNFSM5JR5RIH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHVO75CQ.gif]

yalh76 commented 2 years ago

I am okay with that. I don't know yet how the new config panel works. Maybe soon.

If you need more informations => https://yunohost.org/fr/packaging_apps_config_panel

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:rocket: Test Badge