Use debs for updating instead of relying on ynh helper

MayeulC commented 2 years ago

Problem

closes #22 Yunohost helper doesn't actually upgrade extra dependencies (probably needs an upstream bug report)

Solution

Install debs from the repo and check their sha256sums instead of relying on yunohost's helper or apt.

PR Status

[X] Code finished.
[ ] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[X] Can be reviewed and tested.

Package_check results

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

MayeulC commented 2 years ago

!testme

nathanael-h commented 2 years ago

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you!

MayeulC commented 2 years ago

OK, a few oversights.

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you!

MayeulC commented 2 years ago

OK, checked the syntax this time.

!testme

yunohost-bot commented 2 years ago

:stuck_out_tongue_winking_eye:

MayeulC commented 2 years ago

CI fails on synapse install. I'll test this locally I guess...

Warning: Fatal Python error: GC object already tracked
Warning: Current thread 0x00007fad78ccd740 (most recent call first):
Warning:   File "/opt/yunohost/matrix-synapse/lib/python3.7/site-packages/attr/validators.py", line 356 in __call__
Warning:   File "<attrs generated init synapse.types.RoomStreamToken>", line 12 in __init__
Warning:   File "/opt/yunohost/matrix-synapse/lib/python3.7/site-packages/synapse/types.py", line 676 in <module>
Warning:   File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
Warning:   File "<frozen importlib._bootstrap_external>", line 728 in exec_module
Warning:   File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
Warning:   File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
Warning:   File "<frozen importlib._bootstrap>", line 983 in _find_and_load
Warning:   File "/opt/yunohost/matrix-synapse/lib/python3.7/site-packages/synapse/events/__init__.py", line 39 in <module>
Warning:   File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
Warning:   File "<frozen importlib._bootstrap_external>", line 728 in exec_module
Warning:   File "<frozen importlib._bootstrap>", line 677 in _load_unlocked
Warning:   File "<frozen importlib._bootstrap>", line 967 in _find_and_load_unlocked
Warning:   File "<frozen importlib._bootstrap>", line 983 in _find_and_load
Warning:   File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
Warning:   File "<frozen importlib._bootstrap>", line 1035 in _handle_fromlist
Warning:   File "/opt/yunohost/matrix-synapse/lib/python3.7/site-packages/synapse/app/homeserver.py", line 28 in <module>
Warning:   File "/usr/lib/python3.7/runpy.py", line 85 in _run_code
Warning:   File "/usr/lib/python3.7/runpy.py", line 193 in _run_module_as_main
Warning: ./install: line 217: 13925 Aborted                 python -m synapse.app.homeserver --keys-directory /etc/matrix-$app/ --generate-config --generate-keys --server-name $server_name --report-stats=no -c homeserver.yml
Error: Unable to install synapse: An error occurred inside the app installation script

MayeulC commented 2 years ago

!testme

:crossed_fingers: Now that the CI seems to be working again, it looks like dpkg doesn't install dependencies, so we're using apt-get install, even though it isn't mentioned explicitely in the man it should work (here is one of the sources)

yunohost-bot commented 2 years ago

:carousel_horse:

Gredin67 commented 2 years ago

@MayeulC if you feel like testing a fix to the helpers https://github.com/YunoHost/yunohost/pull/1407/files

Gredin67 commented 2 years ago

Close in favour of https://github.com/YunoHost-Apps/mautrix_signal_ynh/pull/36#issuecomment-1013952807

YunoHost-Apps / mautrix_signal_ynh