YunoHost-Apps / mautrix_signal_ynh

Matrix signal package for YunoHost
GNU Affero General Public License v3.0
4 stars 10 forks source link

Config panel permissions #76

Closed Gredin67 closed 1 year ago

Gredin67 commented 1 year ago

Problem

Solution

Gredin67 commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse: Test Badge

Gredin67 commented 1 year ago

@thardev could you adapt your sed magic for permissions to https://github.com/mautrix/signal/blob/master/mautrix_signal/example-config.yaml#L282-L284 In whatsapp (go) bridges:

    permissions:
        "*": relay
        "example.com": user
        "@admin:example.com": admin

in python bridges

    permissions:
        "*": "relay"
        "example.com": "user"
        "@admin:example.com": "admin"
MayeulC commented 1 year ago

@Gredin67, I don't really see a difference. You don't need to quote simple strings like these in YAML.

The only issue I have is (and I don't know if it's the same issue upstream, but that's certainly an issue when reading/writing the config for ynh helpers) that you can't have the same user in multiple sections, as it's a dictionary, and not a list.

For instance: the following won't work:

permissions:
   "*": relay
   "*": user

Or:

permissions:
   "@admin:matrix.org": admin
   "@admin:matrix.org": user
Gredin67 commented 1 year ago

closing to re-open against #70