YunoHost-Apps / mautrix_signal_ynh

Matrix signal package for YunoHost
GNU Affero General Public License v3.0
4 stars 10 forks source link

packaging v2 #86

Open Gredin67 opened 1 year ago

Gredin67 commented 1 year ago

see https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/pull/112

Gredin67 commented 1 year ago

@thardev would you use your experience to do it here ?

MayeulC commented 1 year ago

Note that upstream is under heavy rewrite: https://github.com/mautrix/signalgo

Gredin67 commented 1 year ago

This would change from a python bridge like packaging to a GO like packaging. Maybe @thardev could try to do the packagingV2 at that time or now ?

oufmilo commented 8 months ago

Maybe waiting the v0.5.0 is done to rewrite the packaging v2 ?

https://github.com/mautrix/signal/blob/main/CHANGELOG.md

thardev commented 8 months ago

Hi 🙂

Sorry for not replying here, just forgot about it... I agree with @oufmilo, if the app is going to be rewrote in a significant way, it would be wise to wait until it's done and then do the refactor

Gredin67 commented 8 months ago

It looks like the main repo has already been moved to Go. I think we can already start to v2 package mautrix_signal by slightly adapting https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/pull/112

The main question is : how to handle migration from python to go ? Do we have to remove and reinstall? Will it keep the same DB and handle migration ? Should we use a new _ynh repo and deprecate the old python one? Just cloning the mautrix_whatsapp_ynh repo would probably be easier.

It would also be a good opportunity to create a main mautrix_go_ynh repo from which all mautrix_go packages would be forked.

Le 29 janvier 2024 10:38:18 GMT+01:00, Dante @.***> a écrit :

Hi 🙂

Sorry for not replying here, just forgot about it... I agree with @oufmilo, if the app is going to be rewrote in a significant way, it would be wise to wait until it's done and then do the refactor

-- Reply to this email directly or view it on GitHub: https://github.com/YunoHost-Apps/mautrix_signal_ynh/issues/86#issuecomment-1914309142 You are receiving this because you authored the thread.

Message ID: @.***>

oufmilo commented 8 months ago

That would mean using git if you don't want to wait for the release, and that's not a good idea.

I'm impatient too, but I miss this package in everyday life

Gredin67 commented 8 months ago

Right, didn't think about it, but I guess the release should come quickly after the repo has been moved.