Fix linter warnings - Githubissues

YunoHost-Apps / mautrix_telegram_ynh

Matrix Telegram pupetting bridge for YunoHost

https://github.com/mautrix/telegram

GNU General Public License v3.0

14 stars 4 forks source link

Fix linter warnings #5

Closed ericgaspar closed 2 years ago

ericgaspar commented 2 years ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished.
[ ] Tested with Package_check.
[ ] Fix or enhancement tested.
[ ] Upgrade from last version tested.
[ ] Can be reviewed and tested.

Package_check results

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you!

benneti commented 2 years ago

thanks, can you rerun the tests?

ericgaspar commented 2 years ago

Yes sure, the test is queuing but at the moment the CI dev is broken: https://ci-apps-dev.yunohost.org/ci/

benneti commented 2 years ago

ah was already wondering about that, as you might have seen in the initial PR. No problem then we can also wait until the ci works again. Do you know how to get access to the testme command of the CI?

ericgaspar commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:carousel_horse:

benneti commented 2 years ago

weird now it was telling me that python3-venv should be installed. Can we try again?

BTW whoom/where do I need to ask to be able to use testme?

benneti commented 2 years ago

OK this error I do not understand at all, is there a way to get the complete log not only what is found here https://ci-apps-dev.yunohost.org/ci/job/3084 ?

ericgaspar commented 2 years ago

complete logs are here: https://ci-apps-dev.yunohost.org/ci/logs/mautrix_telegram_amd64_stable_complete.log

benneti commented 2 years ago

I don't get it, the only thing I can imagine is that matrix is missing in the CI container, can I somehow install it or is it better to tweak the scripts to not rely on it?