search

YunoHost-Apps / mautrix_telegram_ynh

Matrix Telegram pupetting bridge for YunoHost
https://github.com/mautrix/telegram
GNU General Public License v3.0
14 stars 4 forks source link

Change puppet prefix in manifest #54

Open Gredin67 opened 9 months ago

Gredin67 commented 9 months ago

puppet and portal rooms have telegram_ prefix by default. This cannot / should not be changed after successful registration of the bridge as a synapse appservice. So the only way to personalize this is to allow changing it at install as a manifest parameter.

I would advocate for having tg_ as default prefix. But for legacy purpose, changing it is probably a bad idea.

To avoid messing up this setting in the config.yaml fil, a solution would be to have tg_ as an app settings and a config panel setting. The setting however should not be writable in the config panel.

thardev commented 3 months ago

Hey @Gredin67

Thanks for your suggestion. I would be ok with adding this to the manifest as parameter, but I'm not sure if this is too technical to have it there, the manifest has already a decent amount of questions during install, and I'm not sure if this should really be added. We could add it to the config panel and have a setter similar to the botname one, that will retrigger the registration and should work. https://github.com/YunoHost-Apps/mautrix_telegram_ynh/blob/96060c4606737a223ce27c34c388aa2705fb92a4/scripts/config#L73-L89

What do you think?